Skip to content

Commit 03bdfe6

Browse files
blacklightr4sas
authored andcommitted
A more robust logic to parse API settings.
All key-value settings in api.py were parsed through the following syntax: ```python if settings["something"] is None: ... ``` This is problematic because it forces downstream implementations to also provide all the fields, also when they are not required. In particular, when new fields are added, downstream implementations also have to provide them, or the integration will break. The `settings.get("something")` syntax should be preferred, and settings itself should also be initialized to a dict by default to prevent dereferencing a `None` (I mean, if no settings are provided at all the code should probably still break, but with a relevant error instead of a fuzzier `TypeError`). Closes: #51 Closes: #52 Closes: https://github.com/Pioverpie/privatebin-api#12
1 parent 41bc3b3 commit 03bdfe6

File tree

1 file changed

+180
-129
lines changed

1 file changed

+180
-129
lines changed

0 commit comments

Comments
 (0)