tags are not working

[gavD]

I told Radiian my tag would be denzel-sample. AWS actually tags instances as denzel_sample (with an underscore).

this meant that provision.sh could not see my instances to destroy old nodes.

[gavD]

I haven't gotten to the bottom of this yet but I'm leaving the ticket here until I figure it out

[gavD]

ah, ok, so seems like AWS receives the tags fine, but ec2.py converts - to _. I'll keep an eye on it further.

[Stillerman]

ec2.py has a method to_safe that replaces "bad" characters with "_". I think radiian should not allow anything with the "bad" characters in order to avoid confusion.

https://github.com/ansible/ansible/blob/d6b74f8f92632652de8092dfacfb6620b7e8c3bc/contrib/inventory/ec2.py#L1294

[nateabele]

See also #79.