Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: button link variant strange box shadow #691

Open
2 tasks
brokuka opened this issue Jul 31, 2024 · 1 comment
Open
2 tasks

[Bug]: button link variant strange box shadow #691

brokuka opened this issue Jul 31, 2024 · 1 comment
Labels
bug Something isn't working upstream Related to Vue Core or VueUse or Volar or other packages

Comments

@brokuka
Copy link

brokuka commented Jul 31, 2024 •
edited
Loading

Reproduction

https://www.shadcn-vue.com/docs/components/button#link

Describe the bug

Using focus(focus-within) on button has strange corners
image

System Info

docs

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@brokuka brokuka added the bug Something isn't working label Jul 31, 2024
@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Jul 31, 2024 •
edited
Loading

Same goes for other shadcn ports

It seems ring-offset and border-radius are not working well together, maybe in Tailwind v4 it will be resolved by replacing the ring with the outline property

https://tailwindcss.com/blog/tailwindcss-v4-alpha#whats-changed

@sadeghbarati sadeghbarati added the upstream Related to Vue Core or VueUse or Volar or other packages label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream Related to Vue Core or VueUse or Volar or other packages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sadeghbarati @brokuka