Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Combobox multiple select clears search field text on first selection #709

Open
2 tasks
saschwarz opened this issue Aug 12, 2024 · 1 comment
Open
2 tasks
Assignees
Labels
bug Something isn't working upstream Related to Vue Core or VueUse or Volar or other packages

Comments

@saschwarz
Copy link

Reproduction

https://codesandbox.io/p/devbox/shadcn-vue-comboboxdemo-forked-m2576d?file=%2Fsrc%2FApp.vue%3A36%2C40

Describe the bug

In the repro:

  1. click on 'Select framework'
  2. type the letter n in the search box
  3. click on either Nextjs or Nuxt and the search input field is cleared and the full list is redisplayed.

This isn't very helpful for users who want to select multiple entries for the same search text.

System Info

System:
    OS: Linux 6.1 Debian GNU/Linux 12 (bookworm) 12 (bookworm)
    CPU: (2) x64 AMD EPYC
    Memory: 2.32 GB / 4.01 GB
    Container: Yes
    Shell: Unknown
  Binaries:
    Node: 18.20.4 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.7.0 - /usr/local/bin/npm
  npmPackages:
    radix-vue: latest => 1.9.3 
    shadcn-vue: latest => 0.10.5 
    vue: latest => 3.4.36

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@hrynevychroman
Copy link
Collaborator

@saschwarz this is upstream issue inside radix-vue, opened PR which will add clearSearchTermOnSelect props which will fix this 🙌

@hrynevychroman hrynevychroman added the upstream Related to Vue Core or VueUse or Volar or other packages label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Related to Vue Core or VueUse or Volar or other packages
Projects
None yet
Development

No branches or pull requests

2 participants