Skip to content

Commit 493184a

Browse files
committed
Prefer semantic elements
1 parent 5269358 commit 493184a

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

src/components/Banner.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import styled from 'styled-components'
33
import Bruce from '../images/banner.svg'
44
import withSimpleErrorBoundary from '../util/withSimpleErrorBoundary'
55

6-
const BannerWrapper = styled.div`
6+
const BannerWrapper = styled.header`
77
height: 30rem;
88
max-height: 50vh;
99
display: flex;

src/components/ContentArea.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import styled from 'styled-components'
33
import { SIDEBAR_WIDTH } from './Sidebar'
44
import withSimpleErrorBoundary from '../util/withSimpleErrorBoundary'
55

6-
const ContentAreaContainer = styled.div`
6+
const ContentAreaContainer = styled.main`
77
@media only screen and (min-width: 1200px) {
88
margin-left: ${SIDEBAR_WIDTH};
99
}

src/components/Sidebar.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ const LogoContainer = styled.div`
5959
align-items: center;
6060
`
6161

62-
const TreeViewContainer = styled.div`
62+
const TreeViewContainer = styled.nav`
6363
flex: 1;
6464
`
6565

src/partials/ProgrammingExercise.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import withSimpleErrorBoundary from '../util/withSimpleErrorBoundary'
1717

1818
const accentColor = '#FAAA38'
1919

20-
const Wrapper = styled.div`
20+
const ProgrammingExerciseWrapper = styled.section`
2121
padding 1rem;
2222
margin-bottom: 2rem;
2323
border-left: 0.2rem solid ${accentColor};
@@ -174,7 +174,7 @@ class ProgrammingExercise extends React.Component {
174174
}
175175

176176
return (
177-
<Wrapper>
177+
<ProgrammingExerciseWrapper>
178178
<Header>
179179
<StyledIcon icon={icon} size="1x" />
180180
<HeaderMuted>Tehtävä: </HeaderMuted>
@@ -297,7 +297,7 @@ class ProgrammingExercise extends React.Component {
297297
</div>
298298
)}
299299
</Body>
300-
</Wrapper>
300+
</ProgrammingExerciseWrapper>
301301
)
302302
}
303303
}

src/partials/TextBox.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
55
import { faInfoCircle, faUserGraduate } from '@fortawesome/free-solid-svg-icons'
66
import withSimpleErrorBoundary from '../util/withSimpleErrorBoundary'
77

8-
const Wrapper = styled.div`
8+
const Wrapper = styled.aside`
99
padding 1rem;
1010
margin-bottom: 2rem;
1111
border-left: 0.2rem solid var(--color);

src/templates/CourseContentTemplate.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const StyledIcon = styled(FontAwesomeIcon)`
2828
font-size: 1em;
2929
`
3030

31-
const ContentWrapper = styled.div``
31+
const ContentWrapper = styled.article``
3232

3333
const UpLink = styled(Link)`
3434
color: #332c2cb3 !important;

0 commit comments

Comments
 (0)