Rubocop!

Author: metaskills

.rubocop.yml

@@ -0,0 +1,31 @@
+
+AllCops:
+  Include:
+    - '**/Rakefile'
+  Exclude:
+    - 'ext/**/*'
+    - 'ports/**/*'
+    - 'test/**/*'
+    - 'tmp/**/*'
+
+# Redefined
+
+Metrics/LineLength:
+  Max: 120
+
+Metrics/ClassLength:
+  Max: 200
+
+# Disabled
+
+Style/Documentation:
+  Enabled: false
+
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+
+Style/EmptyLinesAroundModuleBody:
+  Enabled: false
+
+Style/EmptyLinesAroundBlockBody:
+  Enabled: false

Rakefile

@@ -8,14 +8,14 @@ require 'rubygems/package_task'
 require_relative './ext/tiny_tds/extconsts'
 
 def test_libs
-  ['lib','test']
+  %w(lib test)
 end
 
 def test_files
   if ENV['TEST_FILES']
-    ENV['TEST_FILES'].split(',').map{ |f| f.strip }.sort
+    ENV['TEST_FILES'].split(',').map(&:strip).sort
   else
-    Dir.glob("test/**/*_test.rb").sort
+    Dir.glob('test/**/*_test.rb').sort
   end
 end
 
@@ -32,7 +32,7 @@ def gem_build_path(spec)
   File.join 'pkg', spec.full_name
 end
 
-gemspec = Gem::Specification::load(File.expand_path('../tiny_tds.gemspec', __FILE__))
+gemspec = Gem::Specification.load(File.expand_path('../tiny_tds.gemspec', __FILE__))
 
 Rake::TestTask.new do |t|
   t.libs = test_libs
@@ -47,18 +47,18 @@ end
 
 task :compile
 
-task :build => [:clean, :compile]
+task build: [:clean, :compile]
 task(:build_quietly) { capture_stds { Rake::Task[:build].invoke } }
 
-task :default => [:build, :test]
+task default: [:build, :test]
 
-Dir["tasks/*.rake"].sort.each { |f| load f }
+Dir['tasks/*.rake'].sort.each { |f| load f }
 
 Rake::ExtensionTask.new('tiny_tds', gemspec) do |ext|
   ext.lib_dir = 'lib/tiny_tds'
   ext.cross_compile = true
   ext.cross_platform = ['x86-mingw32', 'x64-mingw32']
-  ext.cross_config_options += %w[ --disable-lookup --enable-cross-build ]
+  ext.cross_config_options += %w(--disable-lookup --enable-cross-build)
   # Add dependent DLLs to the cross gems
   ext.cross_compiling do |spec|
     platform_host_map =  {
@@ -70,16 +70,16 @@ Rake::ExtensionTask.new('tiny_tds', gemspec) do |ext|
     dlls = [
       "libeay32-1.0.2g-#{host}.dll",
       "ssleay32-1.0.2g-#{host}.dll",
-      "libiconv-2.dll",
-      "libsybdb-5.dll",
+      'libiconv-2.dll',
+      'libsybdb-5.dll'
     ]
     # We don't need the sources in a fat binary gem
-    spec.files = spec.files.reject { |f| f=~/^ports\/archives/ }
+    spec.files = spec.files.reject { |f| f =~ %r{^ports\/archives/} }
     spec.files += dlls.map { |dll| "ports/#{host}/bin/#{File.basename(dll)}" }
     spec.files += Dir.glob('exe/*')
     dlls.each do |dll|
       file "ports/#{host}/bin/#{dll}" do |t|
-        sh "x86_64-w64-mingw32-strip", t.name
+        sh 'x86_64-w64-mingw32-strip', t.name
       end
     end
   end
@@ -90,7 +90,7 @@ task gem_build_path(gemspec) do
   add_file_to_gem gemspec, "ports/archives/freetds-#{FREETDS_VERSION}.tar.bz2"
 end
 
-desc "Build the windows binary gems per rake-compiler-dock"
+desc 'Build the windows binary gems per rake-compiler-dock'
 task 'gem:windows' do
   require 'rake_compiler_dock'
   RakeCompilerDock.sh <<-EOT
@@ -99,8 +99,10 @@ task 'gem:windows' do
 end
 
 def capture_stds
-  pstdout, $stdout = $stdout, StringIO.new
-  pstderr, $stderr = $stderr, StringIO.new
+  pstdout = $stdout
+  $stdout = StringIO.new
+  pstderr = $stderr
+  $stderr = StringIO.new
   yield
   $stdout.string
   $stderr.string

lib/tiny_tds.rb

@@ -10,12 +10,12 @@
 
 # Support multiple ruby versions, fat binaries under Windows.
 if RUBY_PLATFORM =~ /mingw|mswin/ && RUBY_VERSION =~ /(\d+.\d+)/
-  ver = $1
+  ver = Regexp.last_match(1)
   # Set the PATH environment variable, so that the DLLs can be found.
   old_path = ENV['PATH']
   begin
     # Do the same host consolidation as in extconf.rb
-    ports_dir = RbConfig::CONFIG["host"].gsub('i686-pc-mingw32', 'i686-w64-mingw32')
+    ports_dir = RbConfig::CONFIG['host'].gsub('i686-pc-mingw32', 'i686-w64-mingw32')
     ENV['PATH'] = "#{File.expand_path("../../ports/#{ports_dir}/bin", __FILE__)};#{old_path}"
     require "tiny_tds/#{ver}/tiny_tds"
   rescue LoadError
@@ -27,9 +27,9 @@
   # Load dependent shared libraries into the process, so that they are already present,
   # when tiny_tds.so is loaded. This ensures, that shared libraries are loaded even when
   # the path is different between build and run time (e.g. Heroku).
-  ports_libs = File.expand_path("../../ports/#{RbConfig::CONFIG["host"]}/lib/*.so", __FILE__)
+  ports_libs = File.expand_path("../../ports/#{RbConfig::CONFIG['host']}/lib/*.so", __FILE__)
   Dir[ports_libs].each do |lib|
-    require "fiddle"
+    require 'fiddle'
     Fiddle.dlopen(lib)
   end
 

lib/tiny_tds/bin.rb

@@ -29,19 +29,18 @@ def initialize(name)
     def run(*args)
       return nil unless path
       Kernel.system Shellwords.join(args.unshift(path))
-      $?.to_i
+      $CHILD_STATUS.to_i
     end
 
     def path
       return @path if defined?(@path)
-      @path = @exefile && File.exists?(@exefile) ? @exefile : which
+      @path = @exefile && File.exist?(@exefile) ? @exefile : which
     end
 
     def info
       "[TinyTds][v#{TinyTds::VERSION}][#{name}]: #{path}"
     end
 
-
     private
 
     def find_bin
@@ -51,7 +50,7 @@ def find_bin
     def find_exe
       EXTS.each do |ext|
         f = File.join ROOT, 'exe', "#{name}#{ext}"
-        return f if File.exists?(f)
+        return f if File.exist?(f)
       end
       nil
     end
@@ -61,12 +60,12 @@ def which
         EXTS.each do |ext|
           exe = File.expand_path File.join(path, "#{name}#{ext}"), ROOT
           next if exe == @binstub
-          next if !File.executable?(exe)
-          next if !binary?(exe)
+          next unless File.executable?(exe)
+          next unless binary?(exe)
           return exe
         end
       end
-      return nil
+      nil
     end
 
     # Implementation directly copied from ptools.
@@ -77,9 +76,9 @@ def binary?(file)
       bytes = File.stat(file).blksize
       return false unless bytes
       bytes = 4096 if bytes > 4096
-      s = (File.read(file, bytes) || "")
-      s = s.encode('US-ASCII', :undef => :replace).split(//)
-      ((s.size - s.grep(" ".."~").size) / s.size.to_f) > 0.30
+      s = (File.read(file, bytes) || '')
+      s = s.encode('US-ASCII', undef: :replace).split(//)
+      ((s.size - s.grep(' '..'~').size) / s.size.to_f) > 0.30
     end
 
   end

lib/tiny_tds/client.rb

@@ -1,21 +1,19 @@
 module TinyTds
   class Client
 
-    @@default_query_options = {
-      :as => :hash,
-      :symbolize_keys => false,
-      :cache_rows => true,
-      :timezone => :local,
-      :empty_sets => true
+    @default_query_options = {
+      as: :hash,
+      symbolize_keys: false,
+      cache_rows: true,
+      timezone: :local,
+      empty_sets: true
     }
 
     attr_reader :query_options
 
     class << self
 
-      def default_query_options
-        @@default_query_options
-      end
+      attr_reader :default_query_options
 
       # Most, if not all, iconv encoding names can be found by ruby. Just in case, you can
       # overide this method to return a string name that Encoding.find would work with. Default
@@ -25,19 +23,28 @@ def transpose_iconv_encoding(encoding)
         encoding
       end
 
-    end
+      def local_offset
+        ::Time.local(2010).utc_offset.to_r / 86_400
+      end
 
+    end
 
-    def initialize(opts={})
-      raise ArgumentError, 'missing :host option if no :dataserver given' if opts[:dataserver].to_s.empty? && opts[:host].to_s.empty?
+    # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/MethodLength
+    # rubocop:disable Metrics/CyclomaticComplexity
+    # rubocop:disable Metrics/PerceivedComplexity
+    def initialize(opts = {})
+      if opts[:dataserver].to_s.empty? && opts[:host].to_s.empty?
+        raise ArgumentError, 'missing :host option if no :dataserver given'
+      end
       opts[:username] = parse_username(opts)
-      @query_options = @@default_query_options.dup
+      @query_options = self.class.default_query_options.dup
       opts[:password] = opts[:password].to_s if opts[:password] && opts[:password].to_s.strip != ''
       opts[:appname] ||= 'TinyTds'
       opts[:tds_version] = tds_versions_setter(opts)
       opts[:login_timeout] ||= 60
       opts[:timeout] ||= 5
-      opts[:encoding] = (opts[:encoding].nil? || opts[:encoding].downcase == 'utf8') ? 'UTF-8' : opts[:encoding].upcase
+      opts[:encoding] = opts[:encoding].nil? || opts[:encoding].casecmp('utf8').zero? ? 'UTF-8' : opts[:encoding].upcase
       opts[:port] ||= 1433
       opts[:dataserver] = "#{opts[:host]}:#{opts[:port]}" if opts[:dataserver].to_s.empty?
       forced_integer_keys = [:login_timeout, :port, :timeout]
@@ -58,24 +65,19 @@ def active?
       !closed? && !dead?
     end
 
-
     private
 
-    def self.local_offset
-      ::Time.local(2010).utc_offset.to_r / 86400
-    end
-
     def parse_username(opts)
       host = opts[:host]
       username = opts[:username]
       return username if username.nil? || !opts[:azure]
-      return username if username.include?("@") && !username.include?("database.windows.net")
-      user, domain = username.split("@")
+      return username if username.include?('@') && !username.include?('database.windows.net')
+      user, domain = username.split('@')
       domain ||= host
       "#{user}@#{domain.split('.').first}"
     end
 
-    def tds_versions_setter(opts={})
+    def tds_versions_setter(opts = {})
       v = opts[:tds_version] || ENV['TDSVER'] || '7.3'
       TDS_VERSIONS_SETTERS[v.to_s]
     end
@@ -107,19 +109,19 @@ def tds_versions_setter(opts={})
     # The integer values of the constants are poorly chosen.
     #
     TDS_VERSIONS_GETTERS = {
-      0  => {:name => 'DBTDS_UNKNOWN',        :description => 'Unknown'},
-      1  => {:name => 'DBTDS_2_0',            :description => 'Pre 4.0 SQL Server'},
-      2  => {:name => 'DBTDS_3_4',            :description => 'Microsoft SQL Server (3.0)'},
-      3  => {:name => 'DBTDS_4_0',            :description => '4.0 SQL Server'},
-      4  => {:name => 'DBTDS_4_2',            :description => '4.2 SQL Server'},
-      5  => {:name => 'DBTDS_4_6',            :description => '2.0 OpenServer and 4.6 SQL Server.'},
-      6  => {:name => 'DBTDS_4_9_5',          :description => '4.9.5 (NCR) SQL Server'},
-      7  => {:name => 'DBTDS_5_0',            :description => '5.0 SQL Server'},
-      8  => {:name => 'DBTDS_7_0',            :description => 'Microsoft SQL Server 7.0'},
-      9  => {:name => 'DBTDS_7_1/DBTDS_8_0',  :description => 'Microsoft SQL Server 2000'},
-      10 => {:name => 'DBTDS_7_2/DBTDS_9_0',  :description => 'Microsoft SQL Server 2005'},
-      11 => {:name => 'DBTDS_7_3',            :description => 'Microsoft SQL Server 2008'},
-      12 => {:name => 'DBTDS_7_4',            :description => 'Microsoft SQL Server 2012/2014'}
+      0  => { name: 'DBTDS_UNKNOWN',        description: 'Unknown' },
+      1  => { name: 'DBTDS_2_0',            description: 'Pre 4.0 SQL Server' },
+      2  => { name: 'DBTDS_3_4',            description: 'Microsoft SQL Server (3.0)' },
+      3  => { name: 'DBTDS_4_0',            description: '4.0 SQL Server' },
+      4  => { name: 'DBTDS_4_2',            description: '4.2 SQL Server' },
+      5  => { name: 'DBTDS_4_6',            description: '2.0 OpenServer and 4.6 SQL Server.' },
+      6  => { name: 'DBTDS_4_9_5',          description: '4.9.5 (NCR) SQL Server' },
+      7  => { name: 'DBTDS_5_0',            description: '5.0 SQL Server' },
+      8  => { name: 'DBTDS_7_0',            description: 'Microsoft SQL Server 7.0' },
+      9  => { name: 'DBTDS_7_1/DBTDS_8_0',  description: 'Microsoft SQL Server 2000' },
+      10 => { name: 'DBTDS_7_2/DBTDS_9_0',  description: 'Microsoft SQL Server 2005' },
+      11 => { name: 'DBTDS_7_3',            description: 'Microsoft SQL Server 2008' },
+      12 => { name: 'DBTDS_7_4',            description: 'Microsoft SQL Server 2012/2014' }
     }.freeze
 
   end

lib/tiny_tds/error.rb

@@ -10,6 +10,5 @@ def initialize(message)
       @os_error_number = nil
     end
 
-
   end
 end

lib/tiny_tds/result.rb

@@ -1,8 +1,7 @@
 module TinyTds
   class Result
-    
+
     include Enumerable
-    
-    
+
   end
 end

lib/tiny_tds/version.rb

@@ -1,3 +1,3 @@
 module TinyTds
-  VERSION = File.read(File.expand_path("../../../VERSION", __FILE__)).chomp
+  VERSION = File.read(File.expand_path('../../../VERSION', __FILE__)).chomp
 end

tiny_tds.gemspec

@@ -1,6 +1,6 @@
 # -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "tiny_tds/version"
+$LOAD_PATH.push File.expand_path('../lib', __FILE__)
+require 'tiny_tds/version'
 
 Gem::Specification.new do |s|
   s.name          = 'tiny_tds'
@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
   s.description   = 'TinyTDS - A modern, simple and fast FreeTDS library for Ruby using DB-Library. Developed for the ActiveRecord SQL Server adapter.'
   s.files         = `git ls-files`.split("\n") + Dir.glob('exe/*')
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ['lib']
   s.rdoc_options  = ['--charset=UTF-8']
   s.extensions    = ['ext/tiny_tds/extconf.rb']