Skip to content

Commit bbbddf8

Browse files
committed
Use build:images instead of build:all and decouple build task from image-builds
Since the image builds take a long time and the release process is github based now, it's better to separate the tasks. This allows to build the gem without the images. Also name the task for building the images like release:images .
1 parent e72ea58 commit bbbddf8

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

Rakefile

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ namespace :build do
8080
task platform => sdf do
8181
build_mri_images([platform], [local_platform], output: 'load')
8282
end
83-
multitask :all => platform
83+
multitask :images => platform
8484
end
8585

8686
sdf = "tmp/docker/Dockerfile.jruby.#{rake_platform}"
@@ -89,7 +89,7 @@ namespace :build do
8989
task :jruby => sdf do
9090
build_jruby_images([local_platform], output: 'load')
9191
end
92-
multitask :all => :jruby
92+
multitask :images => :jruby
9393

9494
all_mri_images = platforms.map(&:first)
9595
desc "Build images for all MRI platforms in parallel"
@@ -102,14 +102,12 @@ namespace :build do
102102
all_images = all_mri_images + ["jruby"]
103103
desc "Build images for all platforms in parallel"
104104
if ENV['RCD_USE_BUILDX_CACHE']
105-
task :all => all_images
105+
task :images => all_images
106106
else
107-
multitask :all => all_images
107+
multitask :images => all_images
108108
end
109109
end
110110

111-
task :build => "build:all"
112-
113111
namespace :release do
114112
host_pl = host_platforms.map(&:first).join(",")
115113

0 commit comments

Comments
 (0)