-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screening by industries #2272
Comments
Do you know what industries are available? |
I guess the ones used by Yahoo Screener. |
I keep experimenting with industry screening. |
The problem here is that yahoo uses specifically the 'em dash' character. When calling the query request the body gets passed as a json to the requests library. Down the chain the 'json.dumbs' function gets called, which changes the 'em dash' to '\u2014'. Obviously the resulting string is not a valid industry for yahoo, so it returns 0 items. One fix (temporary) would be to go into the requests library to file models.py to line 511. Add 'ensure_ascii=False' as parameter to the complexjson.dumps function. |
I see, thanks. |
@ggeeoorrgg What do you think of my pr? Does it work how you would expect? |
I really appreciate your efforts, thanks. P.S. I've just tried to explore your suggestion, but unfortunately, I didn’t quite get it. I still need a use case. |
Well, to avoid digging too deep, it should be sufficient to do something like this:
And define this somewhere:
It works, but I haven’t done extensive testing. |
Hi!
Is it possible to add a feature for screening by industries?
Currently, I do it like this:
But it looks a bit awkward, doesn't it?
The text was updated successfully, but these errors were encountered: