Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize the exported symbols #592

Open
kingcrimsontianyu opened this issue Jan 22, 2025 · 0 comments
Open

Minimize the exported symbols #592

kingcrimsontianyu opened this issue Jan 22, 2025 · 0 comments
Assignees
@kingcrimsontianyu
Labels
c++ Affects the C++ API of KvikIO improvement Improves an existing functionality

Comments

@kingcrimsontianyu
Copy link
Contributor

cuDF hides the symbol visibility for entities that are not intended to be the public interface. KvikIO should do the same given the benefits described here.

Changes needed

CMake

  • Add to the library the property CXX_VISIBILITY_PRESET hidden (and probably CUDA_VISIBILITY_PRESET hidden as well?)

C++

Related to #442
@kingcrimsontianyu kingcrimsontianyu added c++ Affects the C++ API of KvikIO improvement Improves an existing functionality labels Jan 22, 2025
@kingcrimsontianyu kingcrimsontianyu self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingcrimsontianyu kingcrimsontianyu

Labels
c++ Affects the C++ API of KvikIO improvement Improves an existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kingcrimsontianyu