Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Allow RMM to Handle Using Conda Compilers #539

Closed
aleksficek opened this issue Sep 3, 2020 · 16 comments
Closed

[FEA] Allow RMM to Handle Using Conda Compilers #539

aleksficek opened this issue Sep 3, 2020 · 16 comments

Comments

@aleksficek
Copy link

Is your feature request related to a problem? Please describe.
Currently using conda compilers with RMM results in breakages. RAPIDS is posed to take advantage of anaconda compiler versions of gcc and g++ (https://docs.conda.io/projects/conda-build/en/latest/resources/compiler-tools.html) in the future. This is part of an overarching effort in project scout where developers will be able to one day install the scout conda package which includes gcc, g++ and nvcc conda compilers at specific versions with ccache hooked up for fast compilation.

Describe the solution you'd like
This is similar to the issue and fix as part of #315 but based on my own testing in RMM a similar failure has since resurfaced.

Steps to simulate failure
Conda install conda compilers gcc_linux-64 and gxx_linux-64 to conda environment. Then build the repo and see failures. If this does not simulate the error then the error can be reproduced by first pulling the gpuci/rapidsai:0.15-cuda10.2-devel-ubuntu16.04-py3.7 docker image, cloning the rmm repo, installing conda compilers and then building it.

Additional context
After this is solved, the general plan of attack will be to integrate conda compilers into cuDF and then distribute the requests outwards to each other repo.

@aleksficek aleksficek added ? - Needs Triage Need team to review and classify feature request New feature or request labels Sep 3, 2020
@jrhemstad
Copy link
Contributor

What are the breakages?

@aleksficek
Copy link
Author

It used to be breaking exactly like #315 but as I just tested it, the cmake command worked but the process is now failing at make -j. There's a chance I'm just setting my environment wrong but in that case, all that's needed is a verification that conda compilers are working in rmm.

rmm error.txt

@aleksficek
Copy link
Author

aleksficek commented Sep 4, 2020

Looks like I used an incorrect version of conda's gcc. I'll offload this debugging to one of the members on ops I did a knowledge transfer with and they'll take it from here.

@kkraus14 kkraus14 added CMake conda and removed ? - Needs Triage Need team to review and classify labels Sep 4, 2020
@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@harrism
Copy link
Member

harrism commented Feb 16, 2021

@kkraus14 @aleksficek @mike-wendt is this still relevant?

@kkraus14
Copy link
Contributor

Yes, still relevant

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@mike-wendt
Copy link
Contributor

The current plan is to adopt conda compilers for the RAPIDS libraries in 0.20 when CUDA 10.X support is dropped

@jakirkham
Copy link
Member

Thanks for the update Mike! 😄

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@harrism
Copy link
Member

harrism commented Jul 27, 2021

@beckernick I saw you closed the cuDF equivalent of this issue. Is this issue still relevant or can it be closed?

@beckernick
Copy link
Member

cuDF can build with the conda compilers, but I don't know if RMM can currently. We may want to leave this open until we verify.

@kkraus14
Copy link
Contributor

I can confirm that building RMM CUDA / C++ tests and building the RMM Cython extensions works as expected with the conda compilers with version 9.3.0.

@jakirkham
Copy link
Member

This is also how I've built RMM in the past (though haven't done this recently).

Given the C++ side of RMM is header only, suspect this is a non-issue from that side.

@harrism
Copy link
Member

harrism commented Jul 28, 2021

Thanks @kkraus14 and @jakirkham . Closing.

@harrism harrism closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants