Duplicated database queries during filtering

[lukogites]

I wrote filter:

'leave_type_id' => Filter::make('Typ urlopu/nieobecności') ->select(LeaveType::select(['id', 'name'])->pluck('name', 'id')->toArray()),

I go to the datatable page, open Laravel debugbar and see 6 database queries including 5 duplicates.

Why does this happen and how can it be prevented?

[rizkhal]

That's because you create query LeaveType::select(['id', 'name'])->pluck('name', 'id')->toArray()) inside the filters method..

See WithFilters.php file here.

To solve this issue, you need to create query outside the filters method and place the result of your query

For example

public function leaveTypes(): array
{
   return LeaveType::select(['id', 'name'])->pluck('name', 'id')->toArray();
}

public function filters(): array
{
   return [
       'leave' => Filter::make('Leave')->select($this->leaveTypes()),
   ];
}

[lukogites]

I did as you recommended and the effect is the same. 5 duplicate database queries. :(

[rizkhal]

oh sory my mistake, you need to use property instead of method and place it on mout method.

looks like

public function mount()
{
  $this->options = LeaveType::select(['id', 'name'])->pluck('name', 'id')->toArray();
}

then place options property on your filter select

[lukogites]

Now it works perfectly. Thank you so much for your help!