Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge does not work #23

Open
bennahugo opened this issue Mar 1, 2023 · 1 comment · May be fixed by #24
Open

Merge does not work #23

bennahugo opened this issue Mar 1, 2023 · 1 comment · May be fixed by #24

Comments

@bennahugo
Copy link
Collaborator

Getting

Traceback (most recent call last):
  File "/home/bhugo/LunarPolarimetry/venv/bin/breizorro", line 5, in <module>
    main()
  File "/home/bhugo/LunarPolarimetry/venv/lib/python3.8/site-packages/breizorro/breizorro.py", line 251, in main
    mask_image += fits[0]
numpy.core._exceptions.UFuncTypeError: Cannot cast ufunc 'add' output from dtype('float32') to dtype('bool') with casting rule 'same_kind'

... why are we adding masks --- these are binaries - it is better to just or them...
@bennahugo
Copy link
Collaborator Author

bennahugo commented Mar 1, 2023 •
edited
Loading

While I'm at it I will add an option to and (in other words create ever more restrictive masks). I need this to clean the limb of the S-band moon where I create a torus mask with another program

bennahugo added a commit that referenced this issue Mar 1, 2023
@bennahugo
Fix fits mask merge behaviour
7823dda 
- Fixes #23 -- switch to logical operations
- Creates switch to make ever more restrictive masks during merging
by logical_and vs default of logical_or
@bennahugo bennahugo linked a pull request Mar 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fits mask merge behaviour ratt-ru/breizorro
1 participant
@bennahugo