-
Notifications
You must be signed in to change notification settings - Fork 706
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Search before asking
- I searched the issues and found no similar issues.
KubeRay Component
ray-operator
What happened + What you expected to happen
When ray-operator ConfigMap is enabled via helm, some helm values aren't applied.
Reproduction script
Some helm values, e.g. leaderElectionEnabled and metrics, are passed as flags, see here: https://github.com/ray-project/kuberay/blob/v1.5.1/helm-chart/kuberay-operator/templates/deployment.yaml#L126-L131.
Then these flags get ignored when config file is enabled, see here: https://github.com/ray-project/kuberay/blob/v1.5.1/ray-operator/main.go#L117-L141
Anything else
Not sure what is the best solution:
- Pass configs as both flags and via ConfigMap. Also set default config values when config file is provided.
- Set configs only via ConfigMap without flags.
Are you willing to submit a PR?
- Yes I am willing to submit a PR!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working