Search before asking
KubeRay Component
kubectl-plugin
What happened + What you expected to happen
Related to: #3801
-
Should be ""
|
cmd.Flags().StringVar(&options.outputDir, "out-dir", options.outputDir, "directory to save the logs to") |
-
Can directly use util.RayVersion
|
cmd.Flags().StringVar(&options.image, "image", fmt.Sprintf("rayproject/ray:%s", options.rayVersion), "container image to use") |
|
cmd.Flags().StringVar(&options.image, "image", fmt.Sprintf("rayproject/ray:%s", options.rayVersion), "container image to use") |
For 2., an improvement can be update the image if user specify ray version that's different from default (now there can be some mismatch). Like what we did in create_cluster.go
|
// If the image is the default but the ray version is not the default, set the image to use the specified ray version |
|
if options.image == defaultImageWithTag && options.rayVersion != util.RayVersion { |
|
options.image = fmt.Sprintf("%s:%s", defaultImage, options.rayVersion) |
|
} |
Reproduction script
N/A
Anything else
No response
Are you willing to submit a PR?
Search before asking
KubeRay Component
kubectl-plugin
What happened + What you expected to happen
Related to: #3801
Should be ""
kuberay/kubectl-plugin/pkg/cmd/log/log.go
Line 151 in 94d37f2
Can directly use
util.RayVersionkuberay/kubectl-plugin/pkg/cmd/create/create_workergroup.go
Line 95 in 94d37f2
kuberay/kubectl-plugin/pkg/cmd/job/job_submit.go
Line 172 in 94d37f2
For 2., an improvement can be update the image if user specify ray version that's different from default (now there can be some mismatch). Like what we did in
create_cluster.gokuberay/kubectl-plugin/pkg/cmd/create/create_cluster.go
Lines 167 to 170 in 94d37f2
Reproduction script
N/A
Anything else
No response
Are you willing to submit a PR?