Skip to content

[Epic] [Feature] mTLS follow-ups #5048

Description

@machichima

Related issue

#3974

Description

Based on summary of the previous PR: #4566 (comment)

Docs

Should include following contents

  • Document to teach user now to use this feature
  • Ray currently does not support certificate renewal (application only read cert when starting up), to renew it, user should restart Ray application
  • max num of IPs in cert (default)

Refactor

  1. Extract the part building issuer to a helper function: https://github.com/ray-project/kuberay/pull/4566/changes#r3537218847
  2. refactor test https://github.com/ray-project/kuberay/pull/4566/changes#r3544045185

Bug

  1. Fix update secret on every reconcile: [Feature] Add mTLS Support via Cert Manager to RayCluster #4566 (comment)

e2e test

  1. cross node communication: https://github.com/ray-project/kuberay/pull/4566/changes#r3544071464
  2. autoscaler + mTLS: current test only checks the sidecar has TLS env vars, we should add a case that triggers a scale-up and verifies new worker pods join.

Future Plan

  1. BYOC (bring your own certificate) support -> need further discussion. We can support this if there's user request
  2. supports hostname-based identity instead of pod IP until ray-project/ray#61651 is resolved (ref)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions