Commit 5e83301
committed
Trap unhandled failures
If an exception escapes from the main `cli()` function, we don't handle it. On Node < 16 that results in a successful process exit code even though the process has crashed.
On Node >= 16 this was not a bug because of the stricter handling of unhandled promise rejections.
You can demonstrate the bug by putting a string in `ember-addon.paths` in your app's package.json file. (It's supposed to be an array, and will cause a crash.)1 parent 51b46cc commit 5e83301
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
45 | 48 | | |
0 commit comments