Skip to content

Commit 098070e

Browse files
Esemesekthymikee
authored andcommitted
fix: init template name replacement for "helloworld" (#546)
1 parent 4758e4b commit 098070e

3 files changed

Lines changed: 18 additions & 0 deletions

File tree

packages/cli/src/commands/init/__tests__/validate.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import {validateProjectName} from '../validate';
33
import InvalidNameError from '../errors/InvalidNameError';
44
import ReservedNameError from '../errors/ReservedNameError';
5+
import HelloWorldError from '../errors/HelloWorldError';
56

67
test.each(['projectName', 'ProjectName', 'project_name'])(
78
"'%s' project name should be valid",
@@ -23,6 +24,10 @@ test.each([
2324
name: 'react',
2425
error: ReservedNameError,
2526
},
27+
{
28+
name: 'helloworld_test',
29+
error: HelloWorldError,
30+
},
2631
])("'%s' is invalid name", ({name, error}: {name: string, error: Error}) => {
2732
expect(() => validateProjectName(name)).toThrowError(error);
2833
});
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
// @flow
2+
export default class HelloWorldError extends Error {
3+
constructor() {
4+
super(
5+
'Project name shouldn\'t contain "HelloWorld" name in it, because it is CLI\'s default placeholder name.',
6+
);
7+
}
8+
}

packages/cli/src/commands/init/validate.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// @flow
22
import InvalidNameError from './errors/InvalidNameError';
33
import ReservedNameError from './errors/ReservedNameError';
4+
import HelloWorldError from './errors/HelloWorldError';
45

56
const NAME_REGEX = /^[$A-Z_][0-9A-Z_$]*$/i;
67

@@ -12,4 +13,8 @@ export function validateProjectName(name: string) {
1213
if (name === 'React' || name === 'react') {
1314
throw new ReservedNameError();
1415
}
16+
17+
if (name.match(/helloworld/gi)) {
18+
throw new HelloWorldError();
19+
}
1520
}

0 commit comments

Comments
 (0)