Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect gradle wrapper configuration being pulled when creating a new project #2589

Open
PedroPerpetua opened this issue Jan 29, 2025 · 2 comments

Comments

@PedroPerpetua
Copy link

PedroPerpetua commented Jan 29, 2025

Description

For React Native version 0.76.6 & 0.77.0, the gradle version was bumped to 8.11.1 from 8.10.2 (related commit). However, creating a new React Native project using this CLI (npx @react-native-community/cli init RnDiffApp --version 0.77.0, for example) will generate the android/gradle/wrapper/gradle-wrapper.properties file wrong, still using the old version.

This issue reflects in the rn-diff-purge project, which in turn also causes trouble in the upgrade-helper for people trying to upgrade to these versions, as this change is not accurately reflected there.

Reproducible Demo

Just create a new project on either version (0.76.6 or 0.77.0) and check the generated android/gradle/wrapper/gradle-wrapper.properties file for the gradle version.

@danielJunio0
Copy link

there are a commit in react-native lib to fix this issue in next release.
facebook/react-native@490db92

@PedroPerpetua
Copy link
Author

there are a commit in react-native lib to fix this issue in next release. facebook/react-native@490db92

The commit linked has already been merged and released on React Native; issue seems to be that, for some reason, npx @react-native-community/cli init is not properly including this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants