Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Apparently a typo in .gitignore #29

Closed
iamsaumya opened this issue Mar 10, 2021 · 5 comments
Closed

bug: Apparently a typo in .gitignore #29

iamsaumya opened this issue Mar 10, 2021 · 5 comments
Assignees

Comments

@iamsaumya
Copy link

This line seems to be a typo, I am aware of the package-lock.json but not the package-json.lock file.

package-json.lock

Is it a specific file that npm creates? There is a possibility I don't know about it.

@iamsaumya
Copy link
Author

Adding to that, I don't see package-lock.json in the codebase I believe it should be added to a git repo.

@tewarig
Copy link
Contributor

tewarig commented Mar 10, 2021

well, @iamsaumya I don't think that is a typo.😅 check this.. nodejs/citgm#451

@iamsaumya
Copy link
Author

I see, in that case. The typo package-json.lock should be package-lock.json, Isn't it?

@iamsaumya
Copy link
Author

I think it will better to inform the author of #23 to fix the typo in .gitignore as he is pushing the lock file to repo.

@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 11, 2021

We need a lock file either from npm or yarn. I personally use yarn, but let's keep npm lock files as we are using npm in the build pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants