Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V4] Add support for MenuList checkbox and radio #367

Open
arturbien opened this issue Nov 10, 2022 · 0 comments
Open

[V4] Add support for MenuList checkbox and radio #367

arturbien opened this issue Nov 10, 2022 · 0 comments

Comments

@arturbien
Copy link
Member

We've removed "menu" variant of the Radio and Checkbox component, because this type of thing should be a part of the <MenuList />.

Page 116 https://www.ics.uci.edu/~kobsa/courses/ICS104/course-notes/Microsoft_WindowsGuidelines.pdf
Screenshot 2022-11-10 at 23 45 58

We should think it through really well considering that soon we'll also have to add support for <MenuListItem /> icons.
Screenshot below shows how Material UI handles it. It looks like MenuItem checkbox is just an item with checkmark icon in it, and all stuff around accessibility/state should be handled by devs implementing the menu list checkbox / radio.

Screenshot 2022-11-10 at 23 37 42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant