Update to require PHP 7.1+

Author: WyriHaximus

.github/workflows/ci.yml

@@ -19,11 +19,6 @@ jobs:
           - 7.3
           - 7.2
           - 7.1
-          - 7.0
-          - 5.6
-          - 5.5
-          - 5.4
-          - 5.3
     steps:
       - uses: actions/checkout@v4
       - uses: shivammathur/setup-php@v2
@@ -32,7 +27,7 @@ jobs:
           coverage: xdebug
           ini-file: development
           ini-values: disable_functions='' # do not disable PCNTL functions on PHP < 8.1
-          extensions: sockets, pcntl ${{ matrix.php >= 5.6 && ', event' || '' }} ${{ matrix.php >= 5.4 && ', ev' || '' }}
+          extensions: sockets, pcntl, event, ev
         env:
           fail-fast: true # fail step if any extension can not be installed
       - run: composer install
@@ -56,7 +51,6 @@ jobs:
           - 7.3
           - 7.2
           - 7.1
-          - 7.0
     steps:
       - uses: actions/checkout@v4
       - uses: shivammathur/setup-php@v2
@@ -65,7 +59,7 @@ jobs:
           coverage: xdebug
           ini-file: development
           extensions: sockets, pcntl
-      - name: Install ext-uv on PHP 7+
+      - name: Install ext-uv
         run: |
           sudo apt-get update -q && sudo apt-get install libuv1-dev
           echo "yes" | sudo pecl install ${{ matrix.php >= 8.0 && 'uv-0.3.0' || 'uv-0.2.4' }}
@@ -104,19 +98,3 @@ jobs:
         if: ${{ matrix.php >= 7.3 }}
       - run: vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy
         if: ${{ matrix.php < 7.3 }}
-
-  PHPUnit-hhvm:
-    name: PHPUnit (HHVM)
-    runs-on: ubuntu-22.04
-    continue-on-error: true
-    steps:
-      - uses: actions/checkout@v4
-      - run: cp "$(which composer)" composer.phar && ./composer.phar self-update --2.2 # downgrade Composer for HHVM
-      - name: Run hhvm composer.phar install
-        uses: docker://hhvm/hhvm:3.30-lts-latest
-        with:
-          args: hhvm composer.phar install
-      - name: Run hhvm vendor/bin/phpunit
-        uses: docker://hhvm/hhvm:3.30-lts-latest
-        with:
-          args: hhvm vendor/bin/phpunit

README.md

@@ -330,7 +330,7 @@ A `stream_select()` based event loop.
 This uses the [`stream_select()`](https://www.php.net/manual/en/function.stream-select.php)
 function and is the only implementation that works out of the box with PHP.
 
-This event loop works out of the box on PHP 5.3 through PHP 8+ and HHVM.
+This event loop works out of the box on any PHP version.
 This means that no installation is required and this library works on all
 platforms and supported PHP versions.
 Accordingly, the [`Loop` class](#loop) will use this event loop by default if
@@ -373,7 +373,7 @@ This uses the [`event` PECL extension](https://pecl.php.net/package/event),
 that provides an interface to `libevent` library.
 `libevent` itself supports a number of system-specific backends (epoll, kqueue).
 
-This loop is known to work with PHP 5.4 through PHP 8+.
+This loop is known to work with PHP 7.1 through PHP 8+.
 
 #### ExtEvLoop
 
@@ -384,7 +384,7 @@ that provides an interface to `libev` library.
 `libev` itself supports a number of system-specific backends (epoll, kqueue).
 
 
-This loop is known to work with PHP 5.4 through PHP 8+.
+This loop is known to work with PHP 7.1 through PHP 8+.
 
 #### ExtUvLoop
 
@@ -394,7 +394,7 @@ This loop uses the [`uv` PECL extension](https://pecl.php.net/package/uv),
 that provides an interface to `libuv` library.
 `libuv` itself supports a number of system-specific backends (epoll, kqueue).
 
-This loop is known to work with PHP 7+.
+This loop is known to work with PHP 7.1 through PHP 8+.
 
 ### LoopInterface
 
@@ -830,8 +830,7 @@ composer require react/event-loop:^3@dev
 See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades.
 
 This project aims to run on any platform and thus does not require any PHP
-extensions and supports running on legacy PHP 5.3 through current PHP 8+ and
-HHVM.
+extensions and supports running on PHP 7.1 through current PHP 8+.
 It's *highly recommended to use the latest supported PHP version* for this project.
 
 Installing any of the event loop extensions is suggested, but entirely optional.

composer.json

@@ -26,10 +26,10 @@
         }
     ],
     "require": {
-        "php": ">=5.3.0"
+        "php": ">=7.1"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.6 || ^5.7 || ^4.8.36"
+        "phpunit/phpunit": "^9.6 || ^5.7"
     },
     "suggest": {
         "ext-pcntl": "For signal handling support when using the StreamSelectLoop"

phpunit.xml.legacy

@@ -2,7 +2,7 @@
 
 <!-- PHPUnit configuration file with old format for legacy PHPUnit -->
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/4.8/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/5.7/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          colors="true">
     <testsuites>

src/ExtEvLoop.php

@@ -16,7 +16,7 @@
  * that provides an interface to `libev` library.
  * `libev` itself supports a number of system-specific backends (epoll, kqueue).
  *
- * This loop is known to work with PHP 5.4 through PHP 8+.
+ * This loop is known to work with PHP 7.1 through PHP 8+.
  *
  * @see http://php.net/manual/en/book.ev.php
  * @see https://bitbucket.org/osmanov/pecl-ev/overview

src/ExtEventLoop.php

@@ -16,7 +16,7 @@
  * that provides an interface to `libevent` library.
  * `libevent` itself supports a number of system-specific backends (epoll, kqueue).
  *
- * This loop is known to work with PHP 5.4 through PHP 8+.
+ * This loop is known to work with PHP 7.1 through PHP 8+.
  *
  * @link https://pecl.php.net/package/event
  */
@@ -85,9 +85,7 @@ public function addReadStream($stream, $listener)
 
         // ext-event does not increase refcount on stream resources for PHP 7+
         // manually keep track of stream resource to prevent premature garbage collection
-        if (\PHP_VERSION_ID >= 70000) {
-            $this->readRefs[$key] = $stream;
-        }
+        $this->readRefs[$key] = $stream;
     }
 
     public function addWriteStream($stream, $listener)
@@ -104,9 +102,7 @@ public function addWriteStream($stream, $listener)
 
         // ext-event does not increase refcount on stream resources for PHP 7+
         // manually keep track of stream resource to prevent premature garbage collection
-        if (\PHP_VERSION_ID >= 70000) {
-            $this->writeRefs[$key] = $stream;
-        }
+        $this->writeRefs[$key] = $stream;
     }
 
     public function removeReadStream($stream)

src/ExtUvLoop.php

@@ -13,7 +13,7 @@
  * that provides an interface to `libuv` library.
  * `libuv` itself supports a number of system-specific backends (epoll, kqueue).
  *
- * This loop is known to work with PHP 7+.
+ * This loop is known to work with PHP 7.1 through PHP 8+.
  *
  * @see https://github.com/bwoebi/php-uv
  */

src/StreamSelectLoop.php

@@ -12,7 +12,7 @@
  * This uses the [`stream_select()`](https://www.php.net/manual/en/function.stream-select.php)
  * function and is the only implementation that works out of the box with PHP.
  *
- * This event loop works out of the box on PHP 5.4 through PHP 8+ and HHVM.
+ * This event loop works out of the box on any PHP version.
  * This means that no installation is required and this library works on all
  * platforms and supported PHP versions.
  * Accordingly, the [`Loop` class](#loop) will use this event loop by default if
@@ -302,13 +302,10 @@ private function streamSelect(array &$read, array &$write, $timeout)
             try {
                 $ret = \stream_select($read, $write, $except, $timeout === null ? null : 0, $timeout);
                 \restore_error_handler();
-            } catch (\Throwable $e) { // @codeCoverageIgnoreStart
+            } catch (\Throwable $e) {
                 \restore_error_handler();
                 throw $e;
-            } catch (\Exception $e) {
-                \restore_error_handler();
-                throw $e;
-            } // @codeCoverageIgnoreEnd
+            }
 
             if ($except) {
                 $write = \array_merge($write, $except);

tests/AbstractLoopTest.php

@@ -118,10 +118,6 @@ public function testAddWriteStreamTriggersWhenSocketConnectionSucceeds()
 
     public function testAddWriteStreamTriggersWhenSocketConnectionRefused()
     {
-        if (defined('HHVM_VERSION')) {
-            $this->markTestSkipped('Not supported on HHVM');
-        }
-
         // first verify the operating system actually refuses the connection and no firewall is in place
         // use higher timeout because Windows retires multiple times and has a noticeable delay
         // @link https://stackoverflow.com/questions/19440364/why-do-failed-attempts-of-socket-connect-take-1-sec-on-windows

tests/BinTest.php

@@ -9,10 +9,6 @@ class BinTest extends TestCase
      */
     public function setUpBin()
     {
-        if (!defined('PHP_BINARY') || defined('HHVM_VERSION')) {
-            $this->markTestSkipped('Tests not supported on legacy PHP 5.3 or HHVM');
-        }
-
         chdir(__DIR__ . '/bin/');
     }
 

tests/ExtEventLoopTest.php

@@ -70,29 +70,4 @@ public function writeToStream($stream, $content)
 
         fwrite($stream, $content);
     }
-
-    /**
-     * @group epoll-readable-error
-     */
-    public function testCanUseReadableStreamWithFeatureFds()
-    {
-        if (PHP_VERSION_ID > 70000) {
-            $this->markTestSkipped('Memory stream not supported');
-        }
-
-        $this->loop = $this->createLoop(true);
-
-        $input = fopen('php://temp/maxmemory:0', 'r+');
-
-        fwrite($input, 'x');
-        ftruncate($input, 0);
-
-        $this->loop->addReadStream($input, $this->expectCallableExactly(2));
-
-        fwrite($input, "foo\n");
-        $this->tickLoop($this->loop);
-
-        fwrite($input, "bar\n");
-        $this->tickLoop($this->loop);
-    }
 }

tests/StreamSelectLoopTest.php

@@ -42,10 +42,6 @@ public function testStreamSelectTimeoutEmulation()
 
     public function testStreamSelectReportsWarningForStreamWithFilter()
     {
-        if (defined('HHVM_VERSION')) {
-            $this->markTestSkipped('Not supported on legacy HHVM');
-        }
-
         $stream = tmpfile();
         stream_filter_append($stream, 'string.rot13');
 
@@ -80,10 +76,6 @@ public function testStreamSelectReportsWarningForStreamWithFilter()
 
     public function testStreamSelectThrowsWhenCustomErrorHandlerThrowsForStreamWithFilter()
     {
-        if (defined('HHVM_VERSION')) {
-            $this->markTestSkipped('Not supported on legacy HHVM');
-        }
-
         $stream = tmpfile();
         stream_filter_append($stream, 'string.rot13');