W3C Accessibility Metadata Display Guide#574
Conversation
mickael-menu
force-pushed
the
a11y-guide
branch
from
1dd02ca to
7686bd6
Compare
gautierchomel
left a comment
gautierchomel
left a comment
There was a problem hiding this comment.
I understand that the old printPageNumbers function triggers different information to the new pageBreakMarkers function. If this is the case, I recommend adopting a common behaviour for both pieces of information. See Possible confusion between printPageNumbers and pageBreakMarkers #114 and Legacy printPageNumbers should be adressed in the EPUB techniques
|
That's right, |
There was a problem hiding this comment.
Pull Request Overview
This PR implements the W3C Accessibility Metadata Display Guide to enhance how accessibility metadata is displayed within the application. Key changes include the addition of a new PublicationMetadataView using SwiftUI, renaming of methods and protocols from “infos” to “metadata” across related view controllers and collection cells, removal of an obsolete DetailsTableViewController, and updates to localization scripts and accessibility definitions.
Reviewed Changes
Copilot reviewed 19 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TestApp/Sources/Library/PublicationMetadataView.swift | Added new SwiftUI view for displaying publication and accessibility metadata. |
| TestApp/Sources/Library/PublicationMenuViewController.swift | Renamed infosButtonTapped to metadataButtonTapped to reflect updated functionality. |
| TestApp/Sources/Library/PublicationCollectionViewCell.swift | Updated delegate method from displayInformation to presentMetadata accordingly. |
| TestApp/Sources/Library/LibraryViewController.swift | Replaced use of DetailsTableViewController with PublicationMetadataView via a UIHostingController. |
| TestApp/Sources/Library/LibraryFactory.swift | Removed obsolete factory method for DetailsTableViewController. |
| Sources/Shared/Publication/Accessibility/Accessibility.swift | Updated accessibility feature definitions and deprecation annotations with improved comments. |
| BuildTools/Scripts/convert-a11y-display-guide-localizations.js | Added a script to convert localized files for the accessibility display guide. |
| Others | Minor changes include updating project resources and cleaning up unused files. |
Files not reviewed (6)
- Makefile: Language not supported
- Sources/Shared/Resources/en-US.lproj/W3CAccessibilityMetadataDisplayGuide.strings: Language not supported
- Support/Carthage/.xcodegen: Language not supported
- Support/Carthage/Readium.xcodeproj/project.pbxproj: Language not supported
- TestApp/Sources/Library/Base.lproj/Library.storyboard: Language not supported
- TestApp/Sources/Library/Base.lproj/PublicationMenuViewController.xib: Language not supported
Added
Shared