revert: remove TextChoices enum changes from builds and projects constants

Copilot · humitos · web-flow · commit 3879c2148589 · 2026-04-23T16:10:56.000Z
Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/0029c9eb-3d6c-47a5-be0b-8da81dcc8e68 Co-authored-by: humitos <244656+humitos@users.noreply.github.com>
diff --git a/readthedocs/builds/constants.py b/readthedocs/builds/constants.py
@@ -1,99 +1,73 @@
 """Constants for the builds app."""
 
 from django.conf import settings
-from django.db import models
 from django.utils.translation import gettext_lazy as _
 
 
-class BuildState(models.TextChoices):
-    """Internal state of a build.
-
-    This is not to be confused with external representations of 'status'
-    that are sent back to Git providers.
-    """
-
-    TRIGGERED = "triggered", _("Triggered")
-    CLONING = "cloning", _("Cloning")
-    INSTALLING = "installing", _("Installing")
-    BUILDING = "building", _("Building")
-    UPLOADING = "uploading", _("Uploading")
-    FINISHED = "finished", _("Finished")
-    CANCELLED = "cancelled", _("Cancelled")
-
-
-# Backward-compatible aliases for BuildState
-BUILD_STATE_TRIGGERED = BuildState.TRIGGERED
-BUILD_STATE_CLONING = BuildState.CLONING
-BUILD_STATE_INSTALLING = BuildState.INSTALLING
-BUILD_STATE_BUILDING = BuildState.BUILDING
-BUILD_STATE_UPLOADING = BuildState.UPLOADING
-BUILD_STATE_FINISHED = BuildState.FINISHED
-BUILD_STATE_CANCELLED = BuildState.CANCELLED
-
-BUILD_STATE = BuildState.choices
+# BUILD_STATE is our *INTERNAL* representation of build states.
+# This is not to be confused with external representations of 'status'
+# that are sent back to Git providers.
+BUILD_STATE_TRIGGERED = "triggered"
+BUILD_STATE_CLONING = "cloning"
+BUILD_STATE_INSTALLING = "installing"
+BUILD_STATE_BUILDING = "building"
+BUILD_STATE_UPLOADING = "uploading"
+BUILD_STATE_FINISHED = "finished"
+BUILD_STATE_CANCELLED = "cancelled"
+
+BUILD_STATE = (
+    (BUILD_STATE_TRIGGERED, _("Triggered")),
+    (BUILD_STATE_CLONING, _("Cloning")),
+    (BUILD_STATE_INSTALLING, _("Installing")),
+    (BUILD_STATE_BUILDING, _("Building")),
+    (BUILD_STATE_UPLOADING, _("Uploading")),
+    (BUILD_STATE_FINISHED, _("Finished")),
+    (BUILD_STATE_CANCELLED, _("Cancelled")),
+)
 
 BUILD_FINAL_STATES = (
-    BuildState.FINISHED,
-    BuildState.CANCELLED,
+    BUILD_STATE_FINISHED,
+    BUILD_STATE_CANCELLED,
 )
 
-
-class BuildType(models.TextChoices):
-    """Output format type for a build."""
-
-    HTML = "html", _("HTML")
-    PDF = "pdf", _("PDF")
-    EPUB = "epub", _("Epub")
+BUILD_TYPES = (
+    ("html", _("HTML")),
+    ("pdf", _("PDF")),
+    ("epub", _("Epub")),
     # There is currently no support for building man/dash formats, but we keep
     # it there since the DB might still contain those values for legacy
     # projects.
-    MAN = "man", _("Manpage")
-    DASH = "dash", _("Dash")
-
-
-# Backward-compatible alias
-BUILD_TYPES = BuildType.choices
+    ("man", _("Manpage")),
+    ("dash", _("Dash")),
+)
 
 # Manager name for Internal Versions or Builds.
 # ie: Versions and Builds Excluding pull request/merge request Versions and Builds.
 INTERNAL = "internal"
+# Manager name for External Versions or Builds.
+# ie: Only pull request/merge request Versions and Builds.
+EXTERNAL = "external"
+EXTERNAL_TEXT = _("External")
 
-
-class VersionType(models.TextChoices):
-    """Type of a version."""
-
-    BRANCH = "branch", _("Branch")
-    TAG = "tag", _("Tag")
-    # Manager name for External Versions or Builds.
-    # ie: Only pull request/merge request Versions and Builds.
-    EXTERNAL = "external", _("External")
-    UNKNOWN = "unknown", _("Unknown")
-
-
-# Backward-compatible aliases for VersionType
-BRANCH = VersionType.BRANCH
+BRANCH = "branch"
 BRANCH_TEXT = _("Branch")
-TAG = VersionType.TAG
+TAG = "tag"
 TAG_TEXT = _("Tag")
-EXTERNAL = VersionType.EXTERNAL
-EXTERNAL_TEXT = _("External")
-UNKNOWN = VersionType.UNKNOWN
+UNKNOWN = "unknown"
 UNKNOWN_TEXT = _("Unknown")
 
-VERSION_TYPES = VersionType.choices
-
-
-class ExternalVersionState(models.TextChoices):
-    """State of an external version (pull/merge request)."""
-
-    OPEN = "open", _("Open")
-    CLOSED = "closed", _("Closed")
-
-
-# Backward-compatible aliases for ExternalVersionState
-EXTERNAL_VERSION_STATE_OPEN = ExternalVersionState.OPEN
-EXTERNAL_VERSION_STATE_CLOSED = ExternalVersionState.CLOSED
-EXTERNAL_VERSION_STATES = ExternalVersionState.choices
+VERSION_TYPES = (
+    (BRANCH, BRANCH_TEXT),
+    (TAG, TAG_TEXT),
+    (EXTERNAL, EXTERNAL_TEXT),
+    (UNKNOWN, UNKNOWN_TEXT),
+)
+EXTERNAL_VERSION_STATE_OPEN = "open"
+EXTERNAL_VERSION_STATE_CLOSED = "closed"
+EXTERNAL_VERSION_STATES = (
+    (EXTERNAL_VERSION_STATE_OPEN, _("Open")),
+    (EXTERNAL_VERSION_STATE_CLOSED, _("Closed")),
+)
 
 LATEST = settings.RTD_LATEST
 LATEST_VERBOSE_NAME = settings.RTD_LATEST_VERBOSE_NAME
diff --git a/readthedocs/projects/constants.py b/readthedocs/projects/constants.py
@@ -8,7 +8,6 @@
 import os
 import re
 
-from django.db import models
 from django.utils.translation import gettext_lazy as _
 
 
@@ -89,18 +88,13 @@
 # TODO: Remove this since we only have 1 type.
 REPO_CHOICES = ((REPO_TYPE_GIT, _("Git")),)
 
+PUBLIC = "public"
+PRIVATE = "private"
 
-class Privacy(models.TextChoices):
-    """Privacy level for a project or version."""
-
-    PUBLIC = "public", _("Public")
-    PRIVATE = "private", _("Private")
-
-
-# Backward-compatible aliases for Privacy
-PUBLIC = Privacy.PUBLIC
-PRIVATE = Privacy.PRIVATE
-PRIVACY_CHOICES = Privacy.choices
+PRIVACY_CHOICES = (
+    (PUBLIC, _("Public")),
+    (PRIVATE, _("Private")),
+)
 
 IMPORTANT_VERSION_FILTERS = {
     "slug": "important",
@@ -391,70 +385,58 @@ class Privacy(models.TextChoices):
 GITHUB_BRAND = "GitHub"
 GITLAB_BRAND = "GitLab"
 
+# SSL statuses
+SSL_STATUS_VALID = "valid"
+SSL_STATUS_INVALID = "invalid"
+SSL_STATUS_PENDING = "pending"
+SSL_STATUS_UNKNOWN = "unknown"
+SSL_STATUS_CHOICES = (
+    (SSL_STATUS_VALID, _("Valid and active")),
+    (SSL_STATUS_INVALID, _("Invalid")),
+    (SSL_STATUS_PENDING, _("Pending")),
+    (SSL_STATUS_UNKNOWN, _("Unknown")),
+)
 
-class SSLStatus(models.TextChoices):
-    """SSL certificate status for a custom domain."""
-
-    VALID = "valid", _("Valid and active")
-    INVALID = "invalid", _("Invalid")
-    PENDING = "pending", _("Pending")
-    UNKNOWN = "unknown", _("Unknown")
-
-
-# Backward-compatible aliases for SSLStatus
-SSL_STATUS_VALID = SSLStatus.VALID
-SSL_STATUS_INVALID = SSLStatus.INVALID
-SSL_STATUS_PENDING = SSLStatus.PENDING
-SSL_STATUS_UNKNOWN = SSLStatus.UNKNOWN
-SSL_STATUS_CHOICES = SSLStatus.choices
-
-
-class VersioningScheme(models.TextChoices):
-    """URL scheme for serving documentation."""
-
-    MULTIPLE_VERSIONS_WITH_TRANSLATIONS = (
-        "multiple_versions_with_translations",
+MULTIPLE_VERSIONS_WITH_TRANSLATIONS = "multiple_versions_with_translations"
+MULTIPLE_VERSIONS_WITHOUT_TRANSLATIONS = "multiple_versions_without_translations"
+SINGLE_VERSION_WITHOUT_TRANSLATIONS = "single_version_without_translations"
+VERSIONING_SCHEME_CHOICES = (
+    (
+        MULTIPLE_VERSIONS_WITH_TRANSLATIONS,
         _("Multiple versions with translations (/<language>/<version>/<filename>)"),
-    )
-    MULTIPLE_VERSIONS_WITHOUT_TRANSLATIONS = (
-        "multiple_versions_without_translations",
+    ),
+    (
+        MULTIPLE_VERSIONS_WITHOUT_TRANSLATIONS,
         _("Multiple versions without translations (/<version>/<filename>)"),
-    )
-    SINGLE_VERSION_WITHOUT_TRANSLATIONS = (
-        "single_version_without_translations",
+    ),
+    (
+        SINGLE_VERSION_WITHOUT_TRANSLATIONS,
         _("Single version without translations (/<filename>)"),
-    )
-
-
-# Backward-compatible aliases for VersioningScheme
-MULTIPLE_VERSIONS_WITH_TRANSLATIONS = VersioningScheme.MULTIPLE_VERSIONS_WITH_TRANSLATIONS
-MULTIPLE_VERSIONS_WITHOUT_TRANSLATIONS = VersioningScheme.MULTIPLE_VERSIONS_WITHOUT_TRANSLATIONS
-SINGLE_VERSION_WITHOUT_TRANSLATIONS = VersioningScheme.SINGLE_VERSION_WITHOUT_TRANSLATIONS
-VERSIONING_SCHEME_CHOICES = VersioningScheme.choices
-
-
-class FlyoutSorting(models.TextChoices):
-    """Sorting algorithm for the version flyout."""
-
-    ALPHABETICALLY = "alphabetically", _("Alphabetically")
-    # Compatibility to keep the behavior of the old flyout.
-    # This isn't a good algorithm, but it's a way to keep the old behavior in case we need it.
-    SEMVER_READTHEDOCS_COMPATIBLE = "semver-readthedocs-compatible", _("SemVer (Read the Docs)")
-    # https://pypi.org/project/packaging/
-    PYTHON_PACKAGING = "python-packaging", _("Python Packaging (PEP 440 and PEP 425)")
-    CALVER = "calver", _("CalVer (YYYY.0M.0M)")
-    # Let the user to define a custom pattern and use BumpVer to parse and sort the versions.
-    # https://github.com/mbarkhau/bumpver#pattern-examples
-    CUSTOM_PATTERN = "custom-pattern", _("Define your own pattern")
-
-
-# Backward-compatible aliases for FlyoutSorting
-ADDONS_FLYOUT_SORTING_ALPHABETICALLY = FlyoutSorting.ALPHABETICALLY
-ADDONS_FLYOUT_SORTING_SEMVER_READTHEDOCS_COMPATIBLE = FlyoutSorting.SEMVER_READTHEDOCS_COMPATIBLE
-ADDONS_FLYOUT_SORTING_PYTHON_PACKAGING = FlyoutSorting.PYTHON_PACKAGING
-ADDONS_FLYOUT_SORTING_CALVER = FlyoutSorting.CALVER
-ADDONS_FLYOUT_SORTING_CUSTOM_PATTERN = FlyoutSorting.CUSTOM_PATTERN
-ADDONS_FLYOUT_SORTING_CHOICES = FlyoutSorting.choices
+    ),
+)
+
+
+ADDONS_FLYOUT_SORTING_ALPHABETICALLY = "alphabetically"
+# Compatibility to keep the behavior of the old flyout.
+# This isn't a good algorithm, but it's a way to keep the old behavior in case we need it.
+ADDONS_FLYOUT_SORTING_SEMVER_READTHEDOCS_COMPATIBLE = "semver-readthedocs-compatible"
+# https://pypi.org/project/packaging/
+ADDONS_FLYOUT_SORTING_PYTHON_PACKAGING = "python-packaging"
+ADDONS_FLYOUT_SORTING_CALVER = "calver"
+# Let the user to define a custom pattern and use BumpVer to parse and sort the versions.
+# https://github.com/mbarkhau/bumpver#pattern-examples
+ADDONS_FLYOUT_SORTING_CUSTOM_PATTERN = "custom-pattern"
+
+ADDONS_FLYOUT_SORTING_CHOICES = (
+    (ADDONS_FLYOUT_SORTING_ALPHABETICALLY, _("Alphabetically")),
+    (ADDONS_FLYOUT_SORTING_SEMVER_READTHEDOCS_COMPATIBLE, _("SemVer (Read the Docs)")),
+    (
+        ADDONS_FLYOUT_SORTING_PYTHON_PACKAGING,
+        _("Python Packaging (PEP 440 and PEP 425)"),
+    ),
+    (ADDONS_FLYOUT_SORTING_CALVER, _("CalVer (YYYY.0M.0M)")),
+    (ADDONS_FLYOUT_SORTING_CUSTOM_PATTERN, _("Define your own pattern")),
+)
 
 ADDONS_FLYOUT_POSITION_BOTTOM_LEFT = "bottom-left"
 ADDONS_FLYOUT_POSITION_BOTTOM_RIGHT = "bottom-right"
