Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create performance benchmarks #327

Open
Deraen opened this issue Nov 28, 2017 · 5 comments
Open

Create performance benchmarks #327

Deraen opened this issue Nov 28, 2017 · 5 comments

Comments

@Deraen
Copy link
Member

Deraen commented Nov 28, 2017

A few recent changes have probably touched on performance critical code paths, but I don't currently have any way to test and track performance changes.

@atroche
Copy link

atroche commented Apr 28, 2018

Would it be useful if I tried to implement this or this for reagent, and got numbers for the last few releases? Does anyone know of other relevant benchmarks?

@atroche
Copy link

atroche commented Apr 28, 2018

@atroche
Copy link

atroche commented Apr 28, 2018

Quick snapshot of results for anyone who's curious:

image

https://rawgit.com/krausest/js-framework-benchmark/master/webdriver-ts-results/table.html

@Deraen
Copy link
Member Author

Deraen commented Apr 28, 2018

Yes, I know that one, I implemented Reagent case for that project. It is quite nice tool to compare performance between React wrappers and others, but the standard deviation for results is often quite high (e.g select for 16.4ms vs. 3.9ms stddev). This means this is not very useful tool for comparing performance between two commits with minor changes.

I've been thinking about having two tools (in addition to the js-framework-benchmark). One would be to automatically run some test set automatically for every Reagent commit. This would be very similar to js-framework-benchmark implementation, but if possible, be more accurate. And second tool would be to have some examples and maybe a few test cases for some hot code paths and use some Criterium style tool (benchmark.js?) to benchmark important functions. This would help with optimizing the important functions.

@danielcompton
Copy link
Contributor

There is a Criterium port for ClojureScript floating around somewhere, can't remember where I saw it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants