Merge pull request #1250 from rebing/mfn/authorized-fix-docs

Remove non-functional `$getSelectFields` parameter from `authorize()`

Author: mfn

CHANGELOG.md

@@ -3,6 +3,10 @@ CHANGELOG
 
 [Next release](https://github.com/rebing/graphql-laravel/compare/9.17.0...master)
 
+## Breaking changes
+- Remove `$getSelectFields` parameter from `Field::authorize()` [\#1250 / mfn](https://github.com/rebing/graphql-laravel/pull/1250)
+  it has been non-functional since half a decade
+
 2026-03-21, 10.0.0-RC2
 ----------------------
 

README.md

@@ -1620,12 +1620,11 @@ declare(strict_types = 1);
 namespace App\GraphQL\Queries;
 
 use Illuminate\Support\Facades\Auth;
-use Closure;
 use GraphQL\Type\Definition\ResolveInfo;
 
 class UsersQuery extends Query
 {
-    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null, Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null): bool
     {
         // true, if logged in
         return ! Auth::guest();
@@ -1642,12 +1641,11 @@ declare(strict_types = 1);
 namespace App\GraphQL\Queries;
 
 use Illuminate\Support\Facades\Auth;
-use Closure;
 use GraphQL\Type\Definition\ResolveInfo;
 
 class UsersQuery extends Query
 {
-    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null, Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null): bool
     {
         if (isset($args['id'])) {
             return Auth::id() == $args['id'];
@@ -1667,12 +1665,11 @@ declare(strict_types = 1);
 namespace App\GraphQL\Queries;
 
 use Illuminate\Support\Facades\Auth;
-use Closure;
 use GraphQL\Type\Definition\ResolveInfo;
 
 class UsersQuery extends Query
 {
-    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null, Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null): bool
     {
         if (isset($args['id'])) {
             return Auth::id() == $args['id'];

example/Auth/Authenticate.php

@@ -6,7 +6,7 @@
 
 trait Authenticate
 {
-    public function authorize(array $args)
+    public function authorize($root, array $args, $ctx): bool
     {
         return !Auth::guest();
     }

phpstan.neon.dist

@@ -30,10 +30,6 @@ parameters:
         -
           message: '/Call to an undefined method Mockery\\/'
           identifier: method.notFound
-        # tests/Database/AuthorizeArgsTests/TestAuthorizationArgsQuery.php
-        -
-          message: '/Trying to invoke Closure\|null but it might not be a callable/'
-          identifier: callable.nonCallable
         # Mass ignore the raw array property access used in many tests for now
         # See also https://github.com/larastan/larastan/issues/611
         -

src/Support/Field.php

@@ -36,7 +36,7 @@ abstract class Field
      * @param array<string, mixed> $args
      * @param mixed $ctx
      */
-    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null, ?Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null): bool
     {
         return true;
     }
@@ -247,7 +247,7 @@ protected function originalResolver(): ?Closure
             // 1 - the provided `args` of the query or type (if applicable), empty array otherwise
             // 2 - the `$contextValue` (usually set via a GraphQL execution middleware, e.g. `AddAuthUserContextValueMiddleware`)
             // 3 - \GraphQL\Type\Definition\ResolveInfo as provided by the underlying GraphQL PHP library
-            // 4 (!) - added by this library, encapsulates creating a `SelectFields` instance
+            // 4 (!) - added by this library later via DI, encapsulates creating a `SelectFields` instance; only available for resolve()
             $arguments = \func_get_args();
 
             // Authorize first - prevents unauthenticated users from probing

tests/Database/AuthorizeArgsTests/AuthorizeArgsTest.php

@@ -27,6 +27,7 @@ public function testAuthorizeArgs(): void
 GRAPHQL;
 
         // All relevant test assertions are in \Rebing\GraphQL\Tests\Database\AuthorizeArgsTests\TestAuthorizationArgsQuery::authorize
+        // expectErrors because resolve() returns void on a nonNull(string) field
         $this->httpGraphql($graphql, [
             'expectErrors' => true,
         ]);

tests/Database/AuthorizeArgsTests/TestAuthorizationArgsQuery.php

@@ -3,12 +3,10 @@
 declare(strict_types = 1);
 namespace Rebing\GraphQL\Tests\Database\AuthorizeArgsTests;
 
-use Closure;
 use GraphQL\Type\Definition\ResolveInfo;
 use GraphQL\Type\Definition\Type;
 use PHPUnit\Framework\Assert;
 use Rebing\GraphQL\Support\Query;
-use Rebing\GraphQL\Support\SelectFields;
 
 class TestAuthorizationArgsQuery extends Query
 {
@@ -38,7 +36,6 @@ public function authorize(
         array $args,
         $ctx,
         ?ResolveInfo $resolveInfo = null,
-        ?Closure $getSelectFields = null,
     ): bool {
         Assert::assertNull($root);
 
@@ -51,9 +48,6 @@ public function authorize(
 
         Assert::assertInstanceOf(ResolveInfo::class, $resolveInfo);
 
-        $selectFields = $getSelectFields();
-        Assert::assertInstanceOf(SelectFields::class, $selectFields);
-
         return true;
     }
 

tests/Support/Objects/ExamplesAuthorizeMessageQuery.php

@@ -18,7 +18,7 @@ class ExamplesAuthorizeMessageQuery extends Query
     /**
      * @param array<string,mixed> $args
      */
-    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null, ?Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null): bool
     {
         return false;
     }

tests/Support/Objects/ExamplesAuthorizeQuery.php

@@ -18,7 +18,7 @@ class ExamplesAuthorizeQuery extends Query
     /**
      * @param array<string,mixed> $args
      */
-    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null, ?Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null): bool
     {
         return false;
     }

tests/Unit/ValidationAuthorizationTests/AliasedArgValidationMutation.php

@@ -3,7 +3,6 @@
 declare(strict_types = 1);
 namespace Rebing\GraphQL\Tests\Unit\ValidationAuthorizationTests;
 
-use Closure;
 use GraphQL\Type\Definition\ResolveInfo;
 use GraphQL\Type\Definition\Type;
 use Rebing\GraphQL\Support\Mutation;
@@ -23,7 +22,7 @@ class AliasedArgValidationMutation extends Mutation
     /**
      * @param array<string,mixed> $args
      */
-    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null, ?Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null): bool
     {
         return true;
     }