Skip to content

Commit 5dc35d0

Browse files
committed
update changelog
1 parent 013da98 commit 5dc35d0

File tree

4 files changed

+29
-14
lines changed

4 files changed

+29
-14
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,16 @@ Changelog
179179
## 10.4.1
180180
* Fix ability to "leave the topics along" - thanks [rafilsk0]
181181

182+
## 10.5.0
183+
* Add cancellation support to individual messages for cancellation when lease renewal fails - thanks [hdrachmann]
184+
* Update to Rebus 8.9.0
185+
182186
[benne]: https://github.com/benne
183187
[binick]: https://github.com/binick
184188
[eeskildsen]: https://github.com/eeskildsen
185189
[ehabelgindy]: https://github.com/ehabelgindy
186190
[georgechond94]: https://github.com/georgechond94
191+
[hdrachmann]: https://github.com/hdrachmann
187192
[hjalle]: https://github.com/hjalle
188193
[jorgenbosman]: https://github.com/jorgenbosman
189194
[jr01]: https://github.com/jr01

Rebus.AzureServiceBus.Tests/Rebus.AzureServiceBus.Tests.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
<ProjectReference Include="..\Rebus.AzureServiceBus\Rebus.AzureServiceBus.csproj" />
88
</ItemGroup>
99
<ItemGroup>
10-
<PackageReference Include="microsoft.net.test.sdk" Version="17.13.0" />
11-
<PackageReference Include="nunit" Version="3.14.0" />
12-
<PackageReference Include="NUnit3TestAdapter" Version="5.0.0">
10+
<PackageReference Include="microsoft.net.test.sdk" Version="18.0.0" />
11+
<PackageReference Include="nunit" Version="4.4.0" />
12+
<PackageReference Include="NUnit3TestAdapter" Version="5.2.0">
1313
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1414
<PrivateAssets>all</PrivateAssets>
1515
</PackageReference>
16-
<PackageReference Include="rebus.tests.contracts" Version="8.2.6" />
16+
<PackageReference Include="rebus.tests.contracts" Version="8.9.1" />
1717
</ItemGroup>
1818
<ItemGroup>
1919
<None Update="asb_connection_string.txt">

Rebus.AzureServiceBus/AzureServiceBus/AzureServiceBusTransport.cs

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,11 @@ public async Task<TransportMessage> Receive(ITransactionContext context, Cancell
618618
var messageReceiver = receivedMessage.MessageReceiver;
619619

620620
var renewFailedTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken, _cancellationToken);
621-
_messageRenewerTokenSources.AddOrUpdate(message.MessageId, renewFailedTokenSource, (_, _) => renewFailedTokenSource);
621+
if (!_messageRenewerTokenSources.TryAdd(message.MessageId, renewFailedTokenSource))
622+
{
623+
// should never happen though
624+
renewFailedTokenSource.Dispose();
625+
}
622626

623627
var items = context.Items;
624628
// add the message and its receiver to the context
@@ -641,8 +645,10 @@ public async Task<TransportMessage> Receive(ITransactionContext context, Cancell
641645

642646
context.OnAck(async ctx =>
643647
{
644-
_messageRenewerTokenSources.TryRemove(messageId, out var tokenSource);
645-
tokenSource?.Dispose();
648+
if (_messageRenewerTokenSources.TryRemove(messageId, out var tokenSource))
649+
{
650+
tokenSource.Dispose();
651+
}
646652
_messageLockRenewers.TryRemove(messageId, out _);
647653

648654
// only ACK the message if it's still in the context - this way, carefully crafted
@@ -670,8 +676,10 @@ await messageReceiver
670676

671677
context.OnNack(async ctx =>
672678
{
673-
_messageRenewerTokenSources.TryRemove(messageId, out var tokenSource);
674-
tokenSource?.Dispose();
679+
if (_messageRenewerTokenSources.TryRemove(messageId, out var tokenSource))
680+
{
681+
tokenSource.Dispose();
682+
}
675683
_messageLockRenewers.TryRemove(messageId, out _);
676684

677685
// only NACK the message if it's still in the context - this way, carefully crafted
@@ -702,8 +710,10 @@ await messageReceiver.AbandonMessageAsync(
702710

703711
context.OnDisposed(ctx =>
704712
{
705-
_messageRenewerTokenSources.TryRemove(messageId, out var tokenSource);
706-
tokenSource?.Dispose();
713+
if (_messageRenewerTokenSources.TryRemove(messageId, out var tokenSource))
714+
{
715+
tokenSource.Dispose();
716+
}
707717
_messageLockRenewers.TryRemove(messageId, out _);
708718
});
709719

Rebus.AzureServiceBus/Rebus.AzureServiceBus.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
<PackageReadmeFile>README.md</PackageReadmeFile>
1717
</PropertyGroup>
1818
<ItemGroup>
19-
<PackageReference Include="azure.identity" Version="1.13.2" />
20-
<PackageReference Include="Azure.Messaging.ServiceBus" Version="7.18.4" />
21-
<PackageReference Include="Rebus" Version="8.8.0" />
19+
<PackageReference Include="azure.identity" Version="1.17.0" />
20+
<PackageReference Include="Azure.Messaging.ServiceBus" Version="7.20.1" />
21+
<PackageReference Include="Rebus" Version="8.9.0" />
2222
</ItemGroup>
2323
<ItemGroup>
2424
<None Include="..\artwork\little_rebusbus2_copy-500x500.png">

0 commit comments

Comments
 (0)