Comment Mop: Fix two bugs in app relating to comments that should be removed staying visible #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsvreddit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168
Closes #169
💸 TL;DR
In the latest release of Comment Mop, two regressions were introduced as described in the above two issues. The logic used to find comments to remove was improved to be more efficient, but this changed the behaviour compared to the original version.
🧪 Testing Steps / Validation
Create comment hierarchies on a post as described in the two issues.
Run Comment Mop against the top level comment in the hierarchy, once with "Ignore Distinguished" turned off, and again with it turned on.
Validate that the effect of mopping the thread is correct:
For #168, we should observe that the top level comment where Mop was run is correctly removed. For #169, we should observe that the mop continues below the distinguished comment.
Repeat for the post-level mop (only #169 needs to be tested this time). Observe that any comments beneath a distinguished comment are removed, but the distinguished comment is retained when "Ignore distinguished comments" is selected.
✅ Checks