Move/cleanup/standardize staging MPC secrets for stone-prod-p02 (#8656)

* Delete IBM api key, not use with static VMs
* Use secrets moved in infra vault folder
* Standardize the names, they will be the same on all clusters

For ppc64le, the ssh key is taken from the generated secret from
Terraform, i.e.
production/platform/terraform/generated/stone-prod-p02/ibm-ppc64le-ssh-key.
For now leave it there as all secrets generated from Terraform will be
moved in infrastructure folder as another change.

KFLUXINFRA-2419

Signed-off-by: Hugo Ares <[email protected]>

Author: hugares

components/multi-platform-controller/production-downstream/stone-prod-p02/external-secrets.yaml

@@ -11,7 +11,7 @@ metadata:
 spec:
   dataFrom:
     - extract:
-        key: production/build/multi-platform-controller/internal-prod-aws-account
+        key: production/infrastructure/multi-platform-controller/stone-prod-p02/aws-account
   refreshInterval: 1h
   secretStoreRef:
     kind: ClusterSecretStore
@@ -34,7 +34,7 @@ metadata:
 spec:
   dataFrom:
     - extract:
-        key: production/build/multi-platform-controller/internal-prod-ssh-key
+        key: production/infrastructure/multi-platform-controller/stone-prod-p02/aws-ssh-key
   refreshInterval: 1h
   secretStoreRef:
     kind: ClusterSecretStore
@@ -46,29 +46,6 @@ spec:
 ---
 apiVersion: external-secrets.io/v1beta1
 kind: ExternalSecret
-metadata:
-  name: internal-prod-ibm-api-key
-  namespace: multi-platform-controller
-  labels:
-    build.appstudio.redhat.com/multi-platform-secret: "true"
-  annotations:
-    argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
-    argocd.argoproj.io/sync-wave: "-1"
-spec:
-  dataFrom:
-    - extract:
-        key: production/build/multi-platform-controller/internal-prod-ibm-api-key
-  refreshInterval: 1h
-  secretStoreRef:
-    kind: ClusterSecretStore
-    name: appsre-stonesoup-vault
-  target:
-    creationPolicy: Owner
-    deletionPolicy: Delete
-    name: internal-prod-ibm-api-key
----
-apiVersion: external-secrets.io/v1beta1
-kind: ExternalSecret
 metadata:
   name: ibm-ppc64le-ssh-key
   namespace: multi-platform-controller
@@ -93,7 +70,7 @@ spec:
 apiVersion: external-secrets.io/v1beta1
 kind: ExternalSecret
 metadata:
-  name: ibm-s390x-static-ssh-key
+  name: ibm-s390x-ssh-key
   namespace: multi-platform-controller
   labels:
     build.appstudio.redhat.com/multi-platform-secret: "true"
@@ -103,12 +80,12 @@ metadata:
 spec:
   dataFrom:
     - extract:
-        key: production/build/multi-platform-controller/stone-prod-p02-ibm-s390x-static-ssh-key
+        key: production/infrastructure/multi-platform-controller/stone-prod-p02/ibm-s390x-ssh-key
   refreshInterval: 1h
   secretStoreRef:
     kind: ClusterSecretStore
     name: appsre-stonesoup-vault
   target:
     creationPolicy: Owner
     deletionPolicy: Delete
-    name: ibm-s390x-static-ssh-key
+    name: ibm-s390x-ssh-key

components/multi-platform-controller/production-downstream/stone-prod-p02/host-values.yaml

@@ -297,110 +297,110 @@ staticHosts:
     address: 10.130.79.4
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-2:
     address: 10.130.79.5
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-3:
     address: 10.130.79.6
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-4:
     address: 10.130.79.37
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-5:
     address: 10.130.79.36
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-6:
     address: 10.130.79.68
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-7:
     address: 10.130.79.69
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-8:
     address: 10.130.79.70
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-9:
     address: 10.130.79.71
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-10:
     address: 10.130.79.72
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-11:
     address: 10.130.79.7
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-12:
     address: 10.130.79.8
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-13:
     address: 10.130.79.9
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-14:
     address: 10.130.79.10
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-15:
     address: 10.130.79.38
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root
 
   s390x-static-16:
     address: 10.130.79.39
     concurrency: '4'
     platform: linux/s390x
-    secret: ibm-s390x-static-ssh-key
+    secret: ibm-s390x-ssh-key
     user: root