-
Notifications
You must be signed in to change notification settings - Fork 317
fix(KAR-671): stale ingester pods in the ring #9011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KAR-671): stale ingester pods in the ring #9011
Conversation
🤖 Gemini AI Assistant AvailableHi @olegbet! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @olegbet, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
ea7b15f to
17a54e1
Compare
d157afd to
6a51565
Compare
| # Required for distributed mode - filesystem storage is not supported in distributed deployments | ||
| minio: | ||
| enabled: false | ||
| enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To test on dev, the distributed deployment doesn't get deployed with filesystem storage and I had to switch minio on to see if it is getting deployed properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, I thought we saw that without minio a distributed deployment could be applied just based on in-memory storage (example on kubearchive dev environment) --> kubearchive/kubearchive#1341
This is tested on every CI tests with new PRs on kubearchive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point I started getting troubles deploying dev on resourcehub/clusterhub, not sure if it is related to Loki version or something like that
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olegbet, rh-hemartin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: obetsun <[email protected]> Assisted-by: Cursor AI rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Assisted-by: Cursor AI Signed-off-by: obetsun <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
as filesystem is not supported in distributed mode Assisted-by: Cursor AI Signed-off-by: obetsun <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
6a51565 to
ca44987
Compare
|
/lgtm |
75f0b0a
into
redhat-appstudio:main
|
@olegbet: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: obetsun [email protected]
Assisted-by: Cursor AI
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED