Skip to content

Conversation

@olegbet
Copy link
Contributor

@olegbet olegbet commented Nov 5, 2025

Signed-off-by: obetsun [email protected]

Assisted-by: Cursor AI

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

🤖 Gemini AI Assistant Available

Hi @olegbet! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

🤖 Hi @olegbet, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@olegbet olegbet changed the title WIP: fix(KAR-671): stale inggester pod on kflux-rhel-p01 WIP: fix(KAR-671): stale ingester pod on kflux-rhel-p01 Nov 5, 2025
@olegbet olegbet force-pushed the KAR-671_stale_ingester_pod_on_kflux-rhel-p01 branch from ea7b15f to 17a54e1 Compare November 18, 2025 15:44
@olegbet olegbet changed the title WIP: fix(KAR-671): stale ingester pod on kflux-rhel-p01 WIP: fix(KAR-671): stale ingester pods in the ring Nov 18, 2025
@olegbet olegbet force-pushed the KAR-671_stale_ingester_pod_on_kflux-rhel-p01 branch 2 times, most recently from d157afd to 6a51565 Compare November 22, 2025 16:37
@olegbet olegbet changed the title WIP: fix(KAR-671): stale ingester pods in the ring fix(KAR-671): stale ingester pods in the ring Nov 22, 2025
# Required for distributed mode - filesystem storage is not supported in distributed deployments
minio:
enabled: false
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test on dev, the distributed deployment doesn't get deployed with filesystem storage and I had to switch minio on to see if it is getting deployed properly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I thought we saw that without minio a distributed deployment could be applied just based on in-memory storage (example on kubearchive dev environment) --> kubearchive/kubearchive#1341

This is tested on every CI tests with new PRs on kubearchive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I started getting troubles deploying dev on resourcehub/clusterhub, not sure if it is related to Loki version or something like that

@rh-hemartin
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olegbet, rh-hemartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

obetsun added 8 commits November 24, 2025 16:31
Signed-off-by: obetsun <[email protected]>

Assisted-by: Cursor AI

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Assisted-by: Cursor AI
Signed-off-by: obetsun <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
as filesystem is not supported in distributed mode

Assisted-by: Cursor AI
Signed-off-by: obetsun <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: obetsun <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@olegbet olegbet force-pushed the KAR-671_stale_ingester_pod_on_kflux-rhel-p01 branch from 6a51565 to ca44987 Compare November 24, 2025 15:51
@openshift-ci openshift-ci bot removed the lgtm label Nov 24, 2025
@rh-hemartin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 75f0b0a into redhat-appstudio:main Nov 25, 2025
11 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2025

@olegbet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests ca44987 link unknown /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants