Update Go to v1.24.0 (#188)

Author: sebrandon1

.github/dependabot.yml

@@ -4,12 +4,27 @@ updates:
   - package-ecosystem: gomod
     directory: /
     schedule:
-      interval: daily
+      interval: weekly
+    groups:
+      dev-dependencies:
+        dependency-type: "development"
+      prod-dependencies:
+        dependency-type: "production"
   - package-ecosystem: github-actions
     directory: /
     schedule:
       interval: daily
-  - package-ecosystem: docker
+    groups:
+      dev-dependencies:
+        dependency-type: "development"
+      prod-dependencies:
+        dependency-type: "production"
+  - package-ecosystem: weekly
     directory: /
     schedule:
-      interval: daily
+      interval: weekly
+    groups:
+      dev-dependencies:
+        dependency-type: "development"
+      prod-dependencies:
+        dependency-type: "production"

.github/workflows/pre-main.yaml

@@ -18,19 +18,19 @@ jobs:
       SHELL: /bin/bash
 
     steps:
-      - name: Set up Go 1.23
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.sha }}
+
+      - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.6
+          go-version-file: go.mod
 
       - name: Disable default go problem matcher
         run: echo "::remove-matcher owner=go::"
 
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v4
-        with:
-          ref: ${{ github.sha }}
-
       - name: Extract dependent Pull Requests
         uses: depends-on/depends-on-action@main
         with:
@@ -47,7 +47,7 @@ jobs:
       - name: Golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.63
+          version: v1.64
           args: --timeout 10m0s
 
       - name: Checkmake

.github/workflows/release.yaml

@@ -61,10 +61,15 @@ jobs:
           username: ${{ secrets.QUAY_ROBOT_USERNAME }}
           password: ${{ secrets.QUAY_ROBOT_TOKEN }}
 
-      - name: Set up Go 1.23
+      - name: Check out the repo.
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.ref_name }}
+
+      - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.6
+          go-version-file: go.mod
 
       - name: Disable default go problem matcher
         run: echo "::remove-matcher owner=go::"
@@ -80,11 +85,6 @@ jobs:
           sudo mv ${OPERATOR_SDK_BIN} ${OPERATOR_SDK_DEST_FOLDER}/operator-sdk
           operator-sdk version
 
-      - name: Check out the repo.
-        uses: actions/checkout@v4
-        with:
-          ref: ${{ github.ref_name }}
-
       - name: Build and push sidecar app image
         run: docker build --no-cache -t "${SIDECAR_IMG}" -f certsuite-sidecar/Dockerfile . && docker push ${SIDECAR_IMG}
 

.golangci.yml

@@ -46,7 +46,7 @@ linters:
     - dogsled
     - errcheck
     - exhaustive
-    - exportloopref
+    - copyloopvar
     - funlen
     - goconst
     - gocritic
@@ -85,7 +85,6 @@ linters:
   # - nestif
   # - noctx
   # - prealloc
-  # - exportloopref
   # - structcheck
   # - testpackage
   # - wsl
@@ -111,6 +110,6 @@ issues:
 # golangci.com configuration
 # https://github.com/golangci/golangci/wiki/Configuration
 service:
-  golangci-lint-version: 1.63.x # use the fixed version to not introduce new linters unexpectedly
+  golangci-lint-version: 1.64.x # use the fixed version to not introduce new linters unexpectedly
   prepare:
     - echo "here I can run custom commands, but no preparation needed for this repo"

Dockerfile

@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM mirror.gcr.io/library/golang:1.23 AS builder
+FROM mirror.gcr.io/library/golang:1.24 AS builder
 ARG TARGETOS
 ARG TARGETARCH
 

Makefile

@@ -124,7 +124,7 @@ test-e2e:
 	go test ./test/e2e/ -v -ginkgo.v
 
 GOLANGCI_LINT = $(shell pwd)/bin/golangci-lint
-GOLANGCI_LINT_VERSION ?= v1.63.4
+GOLANGCI_LINT_VERSION ?= v1.64.5
 golangci-lint:
 	@[ -f $(GOLANGCI_LINT) ] || { \
 	set -e ;\
@@ -300,7 +300,7 @@ ifeq (,$(shell which opm 2>/dev/null))
 	set -e ;\
 	mkdir -p $(dir $(OPM)) ;\
 	OS=$(shell go env GOOS) && ARCH=$(shell go env GOARCH) && \
-	curl -sSLo $(OPM) https://github.com/operator-framework/operator-registry/releases/download/v1.23.0/$${OS}-$${ARCH}-opm ;\
+	curl -sSLo $(OPM) https://github.com/operator-framework/operator-registry/releases/download/v1.24.0/$${OS}-$${ARCH}-opm ;\
 	chmod +x $(OPM) ;\
 	}
 else

certsuite-sidecar/Dockerfile

@@ -16,7 +16,7 @@ RUN \
 # Install Go binary and set the PATH
 ENV \
 	GO_DL_URL=https://golang.org/dl \
-	GO_BIN_TAR=go1.23.6.linux-amd64.tar.gz \
+	GO_BIN_TAR=go1.24.0.linux-amd64.tar.gz \
 	GOPATH=/root/go
 ENV GO_BIN_URL_x86_64=${GO_DL_URL}/${GO_BIN_TAR}
 RUN \

go.mod

@@ -1,6 +1,6 @@
 module github.com/redhat-best-practices-for-k8s/certsuite-operator
 
-go 1.23.6
+go 1.24.0
 
 require (
 	github.com/go-logr/logr v1.4.2

scripts/ci/smoke_test.sh

@@ -60,10 +60,10 @@ echo "$crJson" | jq
 
 # Run checks for verdict and counters.
 export EXPECTED_VERDICT=${EXPECTED_VERDICT:-"pass"}
-export EXPECTED_TOTAL_TCS=${EXPECTED_TOTAL_TCS:-"100"}
+export EXPECTED_TOTAL_TCS=${EXPECTED_TOTAL_TCS:-"101"}
 export EXPECTED_FAILED=${EXPECTED_FAILED:-"0"}
 export EXPECTED_PASSED=${EXPECTED_PASSED:-"5"}
-export EXPECTED_SKIPPED=${EXPECTED_SKIPPED:-"95"}
+export EXPECTED_SKIPPED=${EXPECTED_SKIPPED:-"96"}
 
 # Check the verdit is pass
 echo "$crJson" | jq 'if .status.report.verdict == env.EXPECTED_VERDICT then "verdict is "+env.EXPECTED_VERDICT else error("verdict mismatch: \(.status.report.verdict), expected "+env.EXPECTED_VERDICT) end'