Skip to content

Commit 7aeb753

Browse files
authored
ci: Allow testing PRs targetting release branches (#83)
1 parent e308f98 commit 7aeb753

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

.github/workflows/test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
helm repo update
6161
6262
- name: Run chart-testing (lint)
63-
run: ct lint --config ct.yaml --helm-extra-args="--set upstream.backstage.image.tag=latest --set global.clusterRouterBase=app.example.yaml"
63+
run: ct lint --config ct.yaml --target-branch ${{ github.event.pull_request.base.ref }} --helm-extra-args="--set upstream.backstage.image.tag=latest --set global.clusterRouterBase=app.example.yaml"
6464

6565
- name: Create KIND Cluster
6666
uses: helm/kind-action@a1b0e391336a6ee6713a0583f8c6240d70863de3 # v1.12.0
@@ -83,7 +83,7 @@ jobs:
8383

8484
- name: Run chart-testing (latest)
8585
# test with latest stable backstage-showcase release
86-
run: ct install --config ct-install.yaml --helm-extra-set-args="--set=upstream.backstage.image.tag=latest --set=global.clusterRouterBase=app.example.com"
86+
run: ct install --config ct-install.yaml --target-branch ${{ github.event.pull_request.base.ref }} --helm-extra-set-args="--set=upstream.backstage.image.tag=latest --set=global.clusterRouterBase=app.example.com"
8787
test-next:
8888
name: Test Next Release
8989
runs-on: ubuntu-latest
@@ -113,7 +113,7 @@ jobs:
113113
helm repo update
114114
115115
- name: Run chart-testing (lint)
116-
run: ct lint --config ct.yaml --helm-extra-args="--set upstream.backstage.image.tag=next --set global.clusterRouterBase=app.example.yaml"
116+
run: ct lint --config ct.yaml --target-branch ${{ github.event.pull_request.base.ref }} --helm-extra-args="--set upstream.backstage.image.tag=next --set global.clusterRouterBase=app.example.yaml"
117117

118118
- name: Create KIND Cluster
119119
uses: helm/kind-action@a1b0e391336a6ee6713a0583f8c6240d70863de3 # v1.12.0
@@ -136,4 +136,4 @@ jobs:
136136

137137
- name: Run chart-testing (next)
138138
# test with the next backstage-showcase version (main branch)
139-
run: ct install --config ct-install.yaml --helm-extra-set-args="--set=upstream.backstage.image.tag=next --set=global.clusterRouterBase=app.example.com"
139+
run: ct install --config ct-install.yaml --target-branch ${{ github.event.pull_request.base.ref }} --helm-extra-set-args="--set=upstream.backstage.image.tag=next --set=global.clusterRouterBase=app.example.com"

ct.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@ chart-dirs:
22
- charts
33
validate-maintainers: false
44
remote: origin
5-
target-branch: main

0 commit comments

Comments
 (0)