You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Validate tag destination reference format — skillctl tag doesn't validate the destination ref format early; invalid refs fail later with a confusing store error. Add format validation in pkg/oci/tag.go.
Add tests for credential store — credentialStore() and podmanAuthPath() in pkg/oci/push.go have no unit tests. Add tests covering: Docker-only, Podman-only, both present, neither present.
From CodeRabbit review:
REGISTRY_AUTH_FILE support — Honor REGISTRY_AUTH_FILE env var and try all Podman auth paths ($XDG_RUNTIME_DIR/containers/auth.json and $HOME/.config/containers/auth.json) instead of stopping at the first one found.
All are low-severity robustness improvements — no correctness impact.
Minor items deferred from PR #4 code review:
From Kimi-2.5 review:
skillctl tagdoesn't validate the destination ref format early; invalid refs fail later with a confusing store error. Add format validation inpkg/oci/tag.go.credentialStore()andpodmanAuthPath()inpkg/oci/push.gohave no unit tests. Add tests covering: Docker-only, Podman-only, both present, neither present.From CodeRabbit review:
REGISTRY_AUTH_FILEenv var and try all Podman auth paths ($XDG_RUNTIME_DIR/containers/auth.jsonand$HOME/.config/containers/auth.json) instead of stopping at the first one found.All are low-severity robustness improvements — no correctness impact.