[BUG] --set-nic-attribute not persisting changes for NumberVFAdvertised on FC640s

[grafuls]

Your System Details

• Python Version: Python 3.10
• Operating System: Fedora 42
• Target System Type: Dell FC640
• IPMI / Out-of-band Firmware Version:

Describe the bug
Trying to increase the value of NumberVFAdvertised from 64 to 128 the command succeeds but it fails to make it persistent even after a reboot and a racreset.

To Reproduce / What were you Doing?
Steps to reproduce the behavior:

1. badfish -H $(HOSTNAME) -u $(USER) -p $(PASS) --get-nic-attribute NIC.ChassisSlot.4-2-1 --attribute NumberVFAdvertised
2. Verify the value: - INFO - CurrentValue: 64
3. badfish -H $(HOSTNAME) -u $(USER) -p $(PASS) --set-nic-attribute NIC.ChassisSlot.4-2-1 --attribute NumberVFAdvertised --value 128
4. Recheck the value after the reboot: badfish -H $(HOSTNAME) -u $(USER) -p $(PASS) --get-nic-attribute NIC.ChassisSlot.4-2-1 --attribute NumberVFAdvertised
5. Verify it is still at: - INFO - CurrentValue: 64

Expected Behavior
The value change is persistent after reboot

Logs / Screenshots

➜   badfish -H $(HOSTNAME) -u $(USER) -p $(PASS) --get-nic-attribute NIC.ChassisSlot.4-2-1 --attribute NumberVFAdvertised
- INFO     - AttributeName: NumberVFAdvertised
- INFO     - CurrentValue: 64
- INFO     - DisplayName: PCI Virtual Functions Advertised
- INFO     - DisplayOrder: 304
- INFO     - HelpText: None
- INFO     - Hidden: False
- INFO     - Immutable: False
- INFO     - LowerBound: 0
- INFO     - MenuPath: ./
- INFO     - Oem: {'Dell': {'@odata.type': '#DellOemAttributeRegistry.v1_0_0.Attributes', 'GroupDisplayName': 'NIC Configuration', 'GroupName': 'NICConfig'}}
- INFO     - ReadOnly: False
- INFO     - ResetRequired: True
- INFO     - ScalarIncrement: 16
- INFO     - Type: Integer
- INFO     - UpperBound: 128
- INFO     - WarningText: None
- INFO     - WriteOnly: False

badfish -H $(HOSTNAME) -u $(USER) -p $(PASS) --set-nic-attribute NIC.ChassisSlot.4-2-1 --attribute NumberVFAdvertised --value 128
- POLLING: [------------------->] 100% - Host state: On  
- INFO     - Patch command to set network attribute values and create next reboot job PASSED.
- INFO     - Command passed to GracefulRestart server, code return is 204.
- INFO     - Polling for host state: Not Down
- WARNING  - Command failed to On server, host appears to be already in that state.

Additional Details
Add any other context or details about the problem here.

[sraviteja-maker]

@grafuls I have tried similar steps on R740xds as well, NumberVFAdvertised is not persistent after the reboot.

podman run -it --rm quay.io/quads/badfish -H ${HOST_NAME} -u ${BADFISH_USERNAME} -p ${BADFISH_PASSWORD} --get-nic-attribute NIC.Slot.7-1-1 --attribute NumberVFAdvertised | grep -i CurrentValue

- INFO     - CurrentValue: 64

podman run -it --rm quay.io/quads/badfish -H ${HOSTNAME} -u ${BADFISH_USERNAME} -p ${BADFISH_PASSWORD} --get-nic-attribute NIC.Slot.7-1-1 --attribute NumberVFSupported | grep -i CurrentValue

- INFO     - CurrentValue: 128

[sraviteja-maker]

/cc @sferlin