GetRow(i) to return the entire dictionary

[paulflo150]

Since result[i] is being deprecated, is there any chance of adding a GetAll, or something along those lines that returns the entire dictionary?

Currently I have a generic method I return aggregations from based on the type that requests it and then I am passing the entire dictionary back to methods insides these types which then convert the key/ value pairs to the actual object.

This is my flow

   var empty = new T();
   .................
   var hashEntries = result[i].Select(kv => new HashEntry(kv.Key, kv.Value));
   items.Add(empty.BuildObject(hashEntries));

[mgravell]

Reading between the lines, result here is an AggregationResult - is that correct? If not, let me know!

Assuming so: I'm assuming that you are requesting an API on Row that provides access to the fields; that sounds entirely reasonable. I don't like the idea of exposing the underlying dictionary directly (nothing good that way comes), but: we can follow the general pattern of collections, and expose a custom enumerator. I'm taking a look at this in over here - working through checking the API, but fundamentally: result.GetRow(i) becomes treatable as IEnumerable<KeyValuePair<string, RedisValue>>, allowing direct foreach usage, or use with Select et al.

[mgravell]

API PR complete; let me know whether you agree this meets your needs, before we merge anything.

[paulflo150]

Hi @mgravell that is perfect, as this ensures pretty much just a drop in change.

I very much appreciate your quick response and help!