fix(client): include all replica states in ROLE reply type (#3420)

* fix(client): include all replica states in ROLE reply type

* test(client): use two-space indentation in role states types test

* fix(client): drop unreachable unknown from ROLE replica state union

Author: abhijeet117

packages/client/lib/commands/ROLE.ts

@@ -17,7 +17,7 @@ type SlaveRole = [
   role: BlobStringReply<'slave'>,
   masterHost: BlobStringReply,
   masterPort: NumberReply,
-  state: BlobStringReply<'connect' | 'connecting' | 'sync' | 'connected'>,
+  state: BlobStringReply<'connect' | 'connecting' | 'sync' | 'connected' | 'handshake' | 'none'>,
   dataReceived: NumberReply
 ];
 

packages/client/types-tests/role-states.types-test.ts

@@ -0,0 +1,28 @@
+/**
+ * Compile-time regression: the ROLE replica state union must include every
+ * status replication.c emits for a replica (handshake, none, connect,
+ * connecting, sync, connected). Declaring only connect/connecting/sync/
+ * connected rejects valid server states like the handshake phase of a fresh
+ * replica. "unknown" is deliberately absent: replication.c's default branch
+ * is unreachable because slaveIsInHandshakeState() intercepts every
+ * intermediate REPL_STATE_* value before the switch.
+ *
+ * Lives outside `lib/` so it is not picked up by the production build /
+ * typedoc. Checked with `npm run test:types -w @redis/client`.
+ */
+import { createClient } from '../index';
+
+type Client = ReturnType<typeof createClient>;
+type RoleReply = Awaited<ReturnType<Client['role']>>;
+
+export function roleSlaveStateCoversServerStates(reply: RoleReply): void {
+  if (!reply) return;
+  if (reply.role === 'slave') {
+    const state = reply.state;
+    // Comparing against real server states must be a legal check.
+    if (state === 'handshake' || state === 'none') {
+      console.log('transient state:', state);
+    }
+    console.log(state);
+  }
+}