fix #417: fix setting ttl on async pipeline #456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEFORE: - await pipe.expire() triggers ClusterPipeline.__await__ - this triggers .initialize() which delete the pipeline commands AFTER: - pipe.expire() in case of pipeline - await pipe.expire() in case of classic client
…ger/fix-pipeline-ttl
nkanu17
reviewed
Dec 18, 2025
Collaborator
nkanu17
left a comment
nkanu17
left a comment
There was a problem hiding this comment.
The the suggested missing type hint needs to be fixed
| raise NotImplementedError | ||
|
|
||
| @staticmethod | ||
| async def _aexpire(client: AsyncRedisClientOrPipeline, key: str, ttl: int): |
Collaborator
There was a problem hiding this comment.
Suggested change
| async def _aexpire(client: AsyncRedisClientOrPipeline, key: str, ttl: int): | |
| async def _aexpire(client: AsyncRedisClientOrPipeline, key: str, ttl: int) -> None: |
Collaborator
Author
|
We've confirmed that all of the GH Actions checks pass on this code - closing this PR so that #420 can proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating PR #420 on the main repository since the GH Actions test suite has trouble running on PRs originating from a fork.