admin/v2: add public IcebergService#30846
Open
WillemKauf wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new public, read-only Admin API v2 surface (IcebergService) to expose Datalake/Iceberg health and per-partition translation/commit status for consumption by external tooling (e.g. rpk, Console).
Changes:
- Registers a new Admin v2 service (
IcebergService) in the Redpanda admin server wiring. - Implements
GetIcebergStatusto return per-topic/per-partition translated + committed offsets and computed commit lag, plus catalog reachability. - Adds a new Admin v2 protobuf definition and Bazel build targets for the service and its generated code.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/v/redpanda/BUILD | Links the new iceberg admin service library into the redpanda target. |
| src/v/redpanda/application_admin.cc | Registers iceberg_service_impl with the admin server. |
| src/v/redpanda/admin/services/iceberg/iceberg.h | Declares the new Admin v2 iceberg service implementation. |
| src/v/redpanda/admin/services/iceberg/iceberg.cc | Implements GetIcebergStatus, mapping coordinator state and probing catalog health. |
| src/v/redpanda/admin/services/iceberg/BUILD | Adds Bazel target for the new service implementation. |
| proto/redpanda/core/admin/v2/iceberg.proto | Introduces the public Admin v2 IcebergService protobuf API. |
| proto/redpanda/core/admin/v2/BUILD | Adds Bazel proto targets for the new iceberg.proto. |
Add a read-only admin v2 surface over the Datalake subsystem. Unlike the `DatalakeService`, this is intended for public consumption for `rpk` and Console as a way to provide monitoring/health reporting for their Iceberg deployments. Currently, the `IcebergService` provides a way to: 1. Query catalog connectivity on the fly 2. Probe the `datalake::coordinator` for per-partition iceberg state, allowing us to report on metrics like translation lag, commit lag, etc per-partition. Callers can use this data to report e.g. top N laggiest partitions in the cluster. No `rpk` or Console bindings are provided yet.
Collaborator
CI test resultstest results on build#85997
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a read-only admin v2 surface over the Datalake subsystem. Unlike the
DatalakeService, this is intended for public consumption forrpkand Console as a way to provide monitoring/health reporting for their Iceberg deployments.Currently, the
IcebergServiceprovides a way to:datalake::coordinatorfor per-partition iceberg state, allowing us to report on metrics like translation lag, commit lag, etc per-partition. Callers can use this data to report e.g. top N laggiest partitions in the cluster.No
rpkor Console bindings are provided yet.Backports Required
Release Notes