Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: cannot set bodyLimit using server.ts #10958

Closed
1 task
tilmann opened this issue Jul 18, 2024 · 3 comments
Closed
1 task

[Bug?]: cannot set bodyLimit using server.ts #10958

tilmann opened this issue Jul 18, 2024 · 3 comments
Assignees
Labels
bug/needs-info More information is needed for reproduction topic/server Serverful

Comments

@tilmann
Copy link
Contributor

tilmann commented Jul 18, 2024

What's not working?

After updating from v6 to v7 I am trying to migrate from the existing server.config.js to server.ts.

I need to configure the bodyLimit:

If I use the following server.ts and remove the server.config.js the bodyLimit for our deployed app (azure app service in a container) the value in server.ts is ignored.

We are starting the server for our app service using yarn rw serve api --port 8911

How do we reproduce the bug?

  • set the bodyLimit as shown in the code
  • start the server and try a request with some MB in the body

What's your environment? (If it applies)

System:
    OS: macOS 14.5
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.15.0 - /private/var/folders/ys/x3sc951n7zsbd01tmk3j5g9m0000gn/T/xfs-cad50a9b/node
    Yarn: 3.2.3 - /private/var/folders/ys/x3sc951n7zsbd01tmk3j5g9m0000gn/T/xfs-cad50a9b/yarn
  Databases:
    SQLite: 3.43.2 - /usr/bin/sqlite3
  Browsers:
    Edge: 126.0.2592.102
    Safari: 17.5
  npmPackages:
    @redwoodjs/auth-azure-active-directory-setup: 7.7.2 => 7.7.2 
    @redwoodjs/cli-data-migrate: 7.7.2 => 7.7.2 
    @redwoodjs/cli-storybook: 7.7.2 => 7.7.2 
    @redwoodjs/core: 7.7.2 => 7.7.2

Are you interested in working on this?

  • I'm interested in working on this
@tilmann tilmann added the bug/needs-info More information is needed for reproduction label Jul 18, 2024
@Josh-Walker-GM
Copy link
Collaborator

Hey @tilmann 👋

set the bodyLimit as shown in the code

Did you mean to include a code snippet with this or is this covered in our documentation etc?

@Josh-Walker-GM Josh-Walker-GM self-assigned this Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM added the topic/server Serverful label Jul 18, 2024
@dthyresson
Copy link
Contributor

dthyresson commented Jul 21, 2024

I’m picking up issue triage this week from @Josh-Walker-GM and was hoping @tilmann that you could share a reproduction or example. Does this involve uploads?

Might #10573 fix it?

Could you show how you are configuring the api server? Are you using “ configureApiServer”?

@tilmann
Copy link
Contributor Author

tilmann commented Sep 30, 2024

I tested it again with rw 8.3 and it works perfectly.

Thanks team.

@tilmann tilmann closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/needs-info More information is needed for reproduction topic/server Serverful
Projects
Status: Done
Development

No branches or pull requests

3 participants