Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks on % width #11

Open
tgrrr opened this issue Dec 26, 2018 · 2 comments
Open

Breaks on % width #11

tgrrr opened this issue Dec 26, 2018 · 2 comments

Comments

@tgrrr
Copy link

tgrrr commented Dec 26, 2018

Hi,

This follows the exact example: https://github.com/rehooks/component-size/blob/master/example.js exactly, and it breaks when there's a 100% height, (as per the example) or 100vh . Works if we set an exact height with px or em.

I understand it can be wrapped with a div. However, 100vh sets the height to 331px.

Using the example in the readme results in a 16x16 image.

https://codesandbox.io/s/ookwxx927y

Cheers

@rehooks rehooks deleted a comment from infodusha Feb 11, 2019
@fouad
Copy link
Member

fouad commented Feb 11, 2019

thanks for reporting @tgrrr will fix this and publish a new version!

@osdiab
Copy link

osdiab commented Mar 4, 2020

unsure but #28 might solve this, worth a check after it lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants