chore(fix) missing sign return value

Author: 1-leo

packages/ndk/example/bunkers_example.dart

@@ -22,9 +22,9 @@ Future<void> main() async {
       tags: [],
     );
 
-    await ndk.accounts.sign(event);
+    final signedEvent = await ndk.accounts.sign(event);
     log('Event signed successfully!');
-    log('Event ID: ${event.id}');
+    log('Event ID: ${signedEvent.id}');
   } catch (e) {
     log('Error: $e');
   }

packages/ndk/example/nostrconnect_example.dart

@@ -28,9 +28,9 @@ Future<void> main() async {
       tags: [],
     );
 
-    await ndk.accounts.sign(event);
+    final signedEvent = await ndk.accounts.sign(event);
     log('Event signed successfully!');
-    log('Event ID: ${event.id}');
+    log('Event ID: ${signedEvent.id}');
   } catch (e) {
     log('Error: $e');
   }

packages/ndk/lib/data_layer/repositories/signers/nip46_event_signer.dart

@@ -105,9 +105,9 @@ class Nip46EventSigner implements EventSigner {
       content: encryptedRequest!,
     );
 
-    await localEventSigner.sign(requestEvent);
+    final signedEvent = await localEventSigner.sign(requestEvent);
     final broadcastRes = broadcast.broadcast(
-      nostrEvent: requestEvent,
+      nostrEvent: signedEvent,
       specificRelays: connection.relays,
     );
     await broadcastRes.broadcastDoneFuture;

packages/ndk/lib/domain_layer/usecases/bunkers/bunkers.dart

@@ -75,9 +75,9 @@ class Bunkers {
       content: encryptedRequest!,
     );
 
-    await localEventSigner.sign(requestEvent);
+    final signedEvent = await localEventSigner.sign(requestEvent);
     final broadcastRes =
-        _broadcast.broadcast(nostrEvent: requestEvent, specificRelays: relays);
+        _broadcast.broadcast(nostrEvent: signedEvent, specificRelays: relays);
     await broadcastRes.broadcastDoneFuture;
 
     final subscription = _requests.subscription(

packages/ndk/test/signers/nip46_event_signer_test.dart

@@ -62,10 +62,10 @@ void main() {
         content: 'Hello, world!',
       );
 
-      await signer.sign(event);
+      final signedEvent = await signer.sign(event);
 
-      expect(event.id, isNotNull);
-      expect(event.sig, isNotNull);
+      expect(signedEvent.id, isNotNull);
+      expect(signedEvent.sig, isNotNull);
     });
 
     test('getPublicKey should throw when not cached', () {

packages/ndk/test/usecases/lists/lists_test.dart

@@ -48,10 +48,11 @@ void main() async {
       Nip01Event event0 = await bookmarkListKey0.toEvent(signer0);
       Nip01Event event1 = await favoriteRelaysKey1.toEvent(signer1);
 
-      await signer0.sign(event0);
-      await signer1.sign(event1);
+      final signedEvent0 = await signer0.sign(event0);
+      final signedEvent1 = await signer1.sign(event1);
 
-      await relay0.startServer(textNotes: {key0: event0, key1: event1});
+      await relay0
+          .startServer(textNotes: {key0: signedEvent0, key1: signedEvent1});
 
       final cache = MemCacheManager();
       final NdkConfig config = NdkConfig(
@@ -354,12 +355,12 @@ void main() async {
       final oldEvent = await oldSet.toEvent(signer1);
       final newEvent = await newSet.toEvent(signer1);
 
-      await signer1.sign(oldEvent);
-      await signer1.sign(newEvent);
+      final singedOldEvent = await signer1.sign(oldEvent);
+      final signedNewEvent = await signer1.sign(newEvent);
 
       // Save both to cache
-      await ndk.config.cache.saveEvent(oldEvent);
-      await ndk.config.cache.saveEvent(newEvent);
+      await ndk.config.cache.saveEvent(singedOldEvent);
+      await ndk.config.cache.saveEvent(signedNewEvent);
 
       // Fetch the set - should return the newer one
       final fetchedSet = await ndk.lists.getSetByName(
@@ -428,10 +429,10 @@ void main() async {
         content: nip04Content,
       );
 
-      await signer1.sign(nip04Event);
+      final signedNip04Event = await signer1.sign(nip04Event);
 
       // Parse the event back to set - should handle NIP-04 format
-      final parsedSet = await Nip51Set.fromEvent(nip04Event, signer1);
+      final parsedSet = await Nip51Set.fromEvent(signedNip04Event, signer1);
 
       expect(parsedSet, isNotNull);
       expect(parsedSet!.name, "nip04-test-set");

packages/nip07_event_signer/test/nip07_event_signer_test.dart

@@ -335,13 +335,19 @@ void main() {
         createdAt: 1234567890,
       );
 
-      await nip07Signer.sign(event);
+      final signedEvent = await nip07Signer.sign(event);
 
-      expect(event.id, isNotNull);
-      expect(event.id.length, equals(64)); // SHA-256 hash is 64 hex characters
-      expect(RegExp(r'^[a-f0-9]{64}$').hasMatch(event.id), isTrue);
-      expect(event.sig, isNotNull);
-      expect(event.sig!.length, equals(64)); // Signature is 64 hex characters
+      expect(signedEvent.id, isNotNull);
+      expect(
+        signedEvent.id.length,
+        equals(64),
+      ); // SHA-256 hash is 64 hex characters
+      expect(RegExp(r'^[a-f0-9]{64}$').hasMatch(signedEvent.id), isTrue);
+      expect(signedEvent.sig, isNotNull);
+      expect(
+        signedEvent.sig!.length,
+        equals(64),
+      ); // Signature is 64 hex characters
     });
 
     test('encrypt using NIP-04', () async {
@@ -602,14 +608,14 @@ void main() {
           content: 'GM',
         );
 
-        await nip07Signer.sign(event);
+        final signedEvent = await nip07Signer.sign(event);
 
         // Verify event was signed
-        expect(event.id, isNotNull);
-        expect(event.sig, isNotNull);
-        expect(event.id.length, equals(64));
-        expect(RegExp(r'^[a-f0-9]{64}$').hasMatch(event.id), isTrue);
-        expect(event.sig!.length, equals(64));
+        expect(signedEvent.id, isNotNull);
+        expect(signedEvent.sig, isNotNull);
+        expect(signedEvent.id.length, equals(64));
+        expect(RegExp(r'^[a-f0-9]{64}$').hasMatch(signedEvent.id), isTrue);
+        expect(signedEvent.sig!.length, equals(64));
       });
     });
   });

packages/nip07_event_signer/test/test_nip07_event_signer/lib/main.dart

@@ -133,10 +133,10 @@ Future<bool> testSign(Nip07EventSigner nip07Signer) async {
     content: "GM",
   );
 
-  await nip07Signer.sign(event);
+  final signedEvent = await nip07Signer.sign(event);
 
-  return await Bip340EventVerifier().verify(event) &&
-      event.kind == 1 &&
-      event.pubKey == pubKey &&
-      event.content == "GM";
+  return await Bip340EventVerifier().verify(signedEvent) &&
+      signedEvent.kind == 1 &&
+      signedEvent.pubKey == pubKey &&
+      signedEvent.content == "GM";
 }

packages/sample-app/lib/verifiers_performance.dart

@@ -43,10 +43,11 @@ class _VerifiersPerformancePageState extends State<VerifiersPerformancePage> {
       );
     });
 
+    final List<Nip01Event> signedList = [];
     for (final event in list) {
-      await widget.ndk.accounts.sign(event);
+      signedList.add(await widget.ndk.accounts.sign(event));
     }
-    return list;
+    return signedList;
   }
 
   _verifyEventsWaiting({required EventVerifier verifier}) async {