fix: move authCallbackTimeout to NdkConfig

Author: nogringo

packages/ndk/lib/config/request_defaults.dart

@@ -24,4 +24,7 @@ class RequestDefaults {
 
   /// default User-Agent header value used for websocket connections
   static const String DEFAULT_USER_AGENT = "dart-NDK/$packageVersion";
+
+  /// default timeout for AUTH callbacks (how long to wait for AUTH OK)
+  static const Duration DEFAULT_AUTH_CALLBACK_TIMEOUT = Duration(seconds: 30);
 }

packages/ndk/lib/domain_layer/usecases/relay_manager.dart

@@ -5,6 +5,7 @@ import 'package:rxdart/rxdart.dart';
 
 import '../../config/bootstrap_relays.dart';
 import '../../config/relay_defaults.dart';
+import '../../config/request_defaults.dart';
 import '../../shared/decode_nostr_msg/decode_nostr_msg.dart';
 import '../../shared/helpers/relay_helper.dart';
 import '../../shared/isolates/isolate_manager.dart';
@@ -51,7 +52,7 @@ class RelayManager<T> {
   final Map<String, Timer> _pendingAuthTimers = {};
 
   /// timeout for AUTH callbacks (how long to wait for AUTH OK)
-  static const Duration _authCallbackTimeout = Duration(seconds: 30);
+  final Duration authCallbackTimeout;
 
   /// nostr transport factory, to create new transports (usually websocket)
   final NostrTransportFactory nostrTransportFactory;
@@ -82,6 +83,7 @@ class RelayManager<T> {
     List<String>? bootstrapRelays,
     allowReconnect = true,
     this.eagerAuth = false,
+    this.authCallbackTimeout = RequestDefaults.DEFAULT_AUTH_CALLBACK_TIMEOUT,
   }) : _accounts = accounts {
     allowReconnectRelays = allowReconnect;
     _connectSeedRelays(urls: bootstrapRelays ?? DEFAULT_BOOTSTRAP_RELAYS);
@@ -779,7 +781,7 @@ class RelayManager<T> {
         };
 
         // Start timeout timer to clean up orphaned callbacks
-        _pendingAuthTimers[signedAuth.id] = Timer(_authCallbackTimeout, () {
+        _pendingAuthTimers[signedAuth.id] = Timer(authCallbackTimeout, () {
           Logger.log.w(
               "AUTH callback timeout for ${signedAuth.id} on ${relayConnectivity.url}");
           _pendingAuthCallbacks.remove(signedAuth.id);
@@ -854,7 +856,7 @@ class RelayManager<T> {
       };
 
       // Start timeout timer to clean up orphaned callbacks
-      _pendingAuthTimers[signedAuth.id] = Timer(_authCallbackTimeout, () {
+      _pendingAuthTimers[signedAuth.id] = Timer(authCallbackTimeout, () {
         Logger.log.w(
             "AUTH callback timeout for ${signedAuth.id} on ${relayConnectivity.url}");
         _pendingAuthCallbacks.remove(signedAuth.id);

packages/ndk/lib/presentation_layer/init.dart

@@ -108,6 +108,7 @@ class Initialization {
           nostrTransportFactory: _webSocketNostrTransportFactory,
           bootstrapRelays: _ndkConfig.bootstrapRelays,
           eagerAuth: _ndkConfig.eagerAuth,
+          authCallbackTimeout: _ndkConfig.authCallbackTimeout,
         );
 
         engine = RelaySetsEngine(
@@ -125,6 +126,7 @@ class Initialization {
           bootstrapRelays: _ndkConfig.bootstrapRelays,
           engineAdditionalDataFactory: JitEngineRelayConnectivityDataFactory(),
           eagerAuth: _ndkConfig.eagerAuth,
+          authCallbackTimeout: _ndkConfig.authCallbackTimeout,
         );
 
         engine = JitEngine(

packages/ndk/lib/presentation_layer/ndk_config.dart

@@ -66,6 +66,10 @@ class NdkConfig {
   /// False is more privacy-respecting as it doesn't reveal identity until necessary.
   bool eagerAuth;
 
+  /// Timeout for AUTH callbacks (how long to wait for AUTH OK response).
+  /// Defaults to 30 seconds.
+  Duration authCallbackTimeout;
+
   /// Creates a new instance of [NdkConfig].
   ///
   /// [eventVerifier] The verifier used to validate Nostr events. \
@@ -92,6 +96,7 @@ class NdkConfig {
     this.userAgent = RequestDefaults.DEFAULT_USER_AGENT,
     this.fetchedRangesEnabled = false,
     this.eagerAuth = false,
+    this.authCallbackTimeout = RequestDefaults.DEFAULT_AUTH_CALLBACK_TIMEOUT,
   });
 }