Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tsc on changed examples #92

Open
MichaelDeBoey opened this issue Nov 28, 2022 · 4 comments
Open

Run tsc on changed examples #92

MichaelDeBoey opened this issue Nov 28, 2022 · 4 comments

Comments

@MichaelDeBoey
Copy link
Member

As reported by @mcansh in #83 (comment), we had some TypeScript errors when fixing the useActionData/useLoaderData usage.

It would be great if we could run tsc in CI, so we don't have to manually check for these kind of errors.

As I pointed out in #83 (comment), this would require running npm install & sometimes even more (like npx prisma migrate dev), otherwise TypeScript would complain. 😢
This could be solved by having a setup script, but that still would require us to run npm install && npm run -s setup on all example folders (see #83 (comment)).

@mcansh Pointed out this could be prevented by only running the changed example and not the others (see #83 (comment)), which would probably require some git magic, but isn't unnecessary complicated I think.

@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Nov 28, 2022

@mcansh It seems that git diff --dirstat=files,0 HEAD~1 | sed -E 's/^[ 0-9.]+% //g' | sed -E 's/\/.*$//g' | sort | uniq (thanks StackOverflow! 🙏) is what we need 👀

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Jan 27, 2023
@github-actions
Copy link
Contributor

This issue has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from issues that are unactionable. Please reach out if you have more information for us! 🙂

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2023
@MichaelDeBoey MichaelDeBoey reopened this Feb 18, 2023
@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Feb 18, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this issue will be automatically closed.

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 19, 2023
@MichaelDeBoey
Copy link
Member Author

We're working on this, stay tuned!

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant