deno task build fails when ssr: false

[lrowe]

Reproduction

https://github.com/lrowe/deno-react-router

(deno run -A 'npm:create-react-router@latest' deno-react-router followed by setting ssr: false.)

Then run deno task build and see:

[react-router] The requested module 'react-dom/server' does not provide an export named 'renderToPipeableStream'

System Info

% deno --version
deno 2.5.2 (stable, release, aarch64-apple-darwin)
v8 14.0.365.5-rusty
typescript 5.9.2


% deno run -A 'npm:envinfo' --system --npmPackages '{vite,react-router,@react-router/*}' --binaries --browsers
╭ Warning
│
│  Ignored build scripts for packages:
│  npm:fsevents@2.3.3
│  npm:@tailwindcss/oxide@4.1.13
│
│  Lifecycle scripts are only supported when using a `node_modules` directory.
│  Enable it in your deno config file:
│  "nodeModulesDir": "auto"
╰─

  System:
    OS: macOS 15.3.1
    CPU: (8) arm64 Apple M1
    Memory: 60.06 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.14.0 - ~/.nvm/versions/node/v22.14.0/bin/node
    Yarn: 1.22.10 - /opt/homebrew/bin/yarn
    npm: 10.9.2 - ~/.nvm/versions/node/v22.14.0/bin/npm
    Deno: 2.5.2 - ~/.deno/bin/deno
  Browsers:
    Chrome: 140.0.7339.213
    Safari: 18.3
  npmPackages:
    @react-router/dev: ^7.9.2 => 7.9.3 
    @react-router/node: ^7.9.2 => 7.9.3 
    @react-router/serve: ^7.9.2 => 7.9.3 
    react-router: ^7.9.2 => 7.9.3 
    vite: ^7.1.7 => 7.1.7

Used Package Manager

npm

Expected Behavior

deno task build should successfully build when ssr: false as it does when ssr: true.

Actual Behavior

% deno task build
Task build react-router build
vite v7.1.7 building for production...
✓ 44 modules transformed.
build/client/.vite/manifest.json 1.46 kB │ gzip: 0.41 kB
build/client/assets/logo-dark-pX2395Y0.svg 6.10 kB │ gzip: 2.42 kB
build/client/assets/logo-light-CVbx2LBR.svg 6.13 kB │ gzip: 2.43 kB
build/client/assets/root-Dc_0W_VX.css 7.79 kB │ gzip: 2.42 kB
build/client/assets/root-DWBrbSdl.js 1.09 kB │ gzip: 0.62 kB
build/client/assets/home-BjL_nNBQ.js 3.70 kB │ gzip: 1.70 kB
build/client/assets/chunk-NISHYRIK-B1He9qxt.js 115.57 kB │ gzip: 39.30 kB
build/client/assets/entry.client-DG6dFEMS.js 186.52 kB │ gzip: 59.83 kB
✓ built in 1.78s
vite v7.1.7 building SSR bundle for production...
✓ 5 modules transformed.
build/server/.vite/manifest.json 0.23 kB
build/server/assets/server-build-Dc_0W_VX.css 7.79 kB
build/server/index.js 6.02 kB

✓ 1 asset cleaned from React Router server build.
build/server/assets/server-build-Dc_0W_VX.css

✗ Build failed in 104ms
[react-router] The requested module 'react-dom/server' does not provide an export named 'renderToPipeableStream' at file:///Users/lrowe/scratch/deno-react-router/build/server/index.js:6:10
at getPrerenderBuildAndHandler (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/@React-router+dev@7.9.3/node_modules/@react-router/dev/dist/vite.js:4114:15)
at handleSpaMode (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/@React-router+dev@7.9.3/node_modules/@react-router/dev/dist/vite.js:4122:28)
at Object.handler (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/@React-router+dev@7.9.3/node_modules/@react-router/dev/dist/vite.js:3532:13)
at async Promise.all (index 0)
at PluginDriver.hookParallel (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/rollup@4.52.3/node_modules/rollup/dist/es/shared/node-entry.js:22335:9)
at /Users/lrowe/scratch/deno-react-router/node_modules/.deno/rollup@4.52.3/node_modules/rollup/dist/es/shared/node-entry.js:23417:13
at catchUnfinishedHookActions (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/rollup@4.52.3/node_modules/rollup/dist/es/shared/node-entry.js:22779:16)
at buildEnvironment (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/vite@7.1.7/node_modules/vite/dist/node/chunks/dep-Bm2ujbhY.js:33862:64)
at Object.build (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/vite@7.1.7/node_modules/vite/dist/node/chunks/dep-Bm2ujbhY.js:34220:19)
at buildEnvironment (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/@React-router+dev@7.9.3/node_modules/@react-router/dev/dist/cli/index.js:1981:5) {
code: "PLUGIN_ERROR",
pluginCode: "ERR_MODULE_NOT_FOUND",
plugin: "react-router",
hook: "writeBundle"
}

[lrowe]

As a workaround adding a deno.json file with the following content allows deno task build to complete successfully:

{
  "imports": {
    "react-dom/server": "./node_modules/react-dom/server.node.js"
  }
}

[timdorr]

You should use the deno template: deno run -A 'npx create-react-router@latest --template remix-run/react-router-templates/deno' deno-react-route

[lrowe]

Unforunately this also fails after setting ssr: false. Repro: https://github.com/lrowe/deno-react-router/tree/deno-template

deno run -A npm:create-react-router@latest --template remix-run/react-router-templates/deno deno-react-router and then set ssr: false

% deno task build
Task build deno run -A npm:@react-router/dev@7.6.1 build
Using Vite Environment API (experimental)
vite v6.3.5 building for production...
✓ 15 modules transformed.
✗ Build failed in 139ms
[react-router:route-exports] SPA Mode: 1 invalid route export(s) in `routes/home.tsx`: `loader`. See https://reactrouter.com/how-to/spa for more information.
file: /Users/lrowe/scratch/deno-react-router/app/routes/home.tsx
    at Object.transform (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/@react-router+dev@7.6.1/node_modules/@react-router/dev/dist/vite.js:3762:19)
    at Object.handler (/Users/lrowe/scratch/deno-react-router/node_modules/.deno/vite@6.3.5/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:46508:15)
    at /Users/lrowe/scratch/deno-react-router/node_modules/.deno/rollup@4.52.3/node_modules/rollup/dist/es/shared/node-entry.js:22425:40
    at eventLoopTick (ext:core/01_core.js:179:7) {
  code: "PLUGIN_ERROR",
  plugin: "react-router:route-exports",
  hook: "transform",
  id: "/Users/lrowe/scratch/deno-react-router/app/routes/home.tsx",
  watchFiles: [
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/@react-router+dev@7.6.1/node_modules/@react-router/dev/dist/config/defaults/entry.client.tsx",
    "/Users/lrowe/scratch/deno-react-router/app/root.tsx",
    "/Users/lrowe/scratch/deno-react-router/app/routes/home.tsx",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react@19.1.0/node_modules/react/jsx-runtime.js",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react@19.1.0/node_modules/react/index.js",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react-dom@19.1.0/node_modules/react-dom/client.js",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react-router@7.6.1/node_modules/react-router/dist/development/dom-export.mjs",
    "/Users/lrowe/scratch/deno-react-router/package.json",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react-dom@19.1.0/node_modules/react-dom/cjs/react-dom-client.production.js",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react@19.1.0/node_modules/react/cjs/react-jsx-runtime.production.js",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react@19.1.0/node_modules/react/cjs/react.production.js",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react-dom@19.1.0/node_modules/react-dom/index.js",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/react-router@7.6.1/node_modules/react-router/dist/development/chunk-DQRVZFIR.mjs",
    "/Users/lrowe/scratch/deno-react-router/node_modules/.deno/scheduler@0.26.0/node_modules/scheduler/index.js"
  ]
}

[lrowe]

So the error here seem to just be a result of the default generated code in the deno template not being compatible with ssr: false mode, changing it to match the code from the default template works.

However deno check still fails with the following:

% deno check
error: Unsupported scheme "virtual" for module "virtual:react-router/server-build". Supported schemes:
 - "blob"
 - "data"
 - "file"
 - "http"
 - "https"
 - "jsr"
 - "npm"
    at file:///Users/lrowe/scratch/deno-react-router/.react-router/types/+server-build.d.ts:3:16

That can be fixed with the following change:

diff --git a/deno.jsonc b/deno.jsonc
index 87483a3..8158471 100644
--- a/deno.jsonc
+++ b/deno.jsonc
@@ -17,6 +17,7 @@
     }
   },
   "imports": {
+    "virtual:react-router/server-build": "./.react-router/types/+server-build.d.ts",
     "@std/http": "jsr:@std/http@^1.0.16",
     "~/": "./app/",
     "@deno/vite-plugin": "npm:@deno/vite-plugin@1.0.4",

While the template uses an old version of Vite it is compatible with the latest versions when updating everything. The next release of the deno-vite-plugin should fix the warning: denoland/deno-vite-plugin#81

However given the other issues with the deno-vite-plugin I'm not sure whether it makes sense to use that or not given deno is now mostly compatible with vite in a package.json project.