Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from modal context #439

Open
joseplayero opened this issue Oct 9, 2024 · 1 comment
Open

Migrate away from modal context #439

joseplayero opened this issue Oct 9, 2024 · 1 comment

Comments

@joseplayero
Copy link
Collaborator

We should have a shadcn dialog component that we use for every modal and then whenever a modal is needed, the component that generates the component can just import the child content that goes inside the modal/dialog. That will make the codebase simpler and easier to understand in my opinion

@milaiwi do you have thoughts on matter?

@milaiwi
Copy link
Collaborator

milaiwi commented Oct 9, 2024

Yeah, that'd be much better. So essentially defining an export ReusableDialog that another component imports and passes it's own CustomContent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants