Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - no valid commits should not fail #16

Open
anden-dev opened this issue Feb 10, 2023 · 1 comment
Open

Feature Request - no valid commits should not fail #16

anden-dev opened this issue Feb 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@anden-dev
Copy link
Contributor

anden-dev commented Feb 10, 2023

Love the action: I use it to draft release notes with writeToFile: false

At the moment the action will fail if there are no valid commits.

when there are no valid commits it fails with:

Error: No valid commits parsed since previous tag.

I would love to be able to skip the next step (for me here drafting the release) with an if like this:

if: >-
  steps.changelog.outputs.changes  != 'NA'

If there are no valid commits just return 'NA' or '' when not writing to file.
This could also be just an additional mode failWhenResultEmpty: true|false where true is the default and the current behaviour.

Cheers,
Andreas

@NGPixel NGPixel added the enhancement New feature or request label Feb 22, 2023
@rhenwinch
Copy link

hey @anden-dev,

might be an old issue but would you mind sharing (if you have one) a temporary workaround for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants