Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Insert Image in Markdown editor #803

Closed
3 of 6 tasks
NGPixel opened this issue Apr 10, 2019 · 14 comments
Closed
3 of 6 tasks

[FEAT] Insert Image in Markdown editor #803

NGPixel opened this issue Apr 10, 2019 · 14 comments
Assignees

Comments

@NGPixel
Copy link
Member

NGPixel commented Apr 10, 2019

Implement insert image functionality into the Markdown editor.

  • Upload new images
  • Fetch remote image
  • Perform file manager operations like rename, move and delete
  • Support nested folders
  • Add basic image editing capabilities
  • Inline paste image
@NGPixel NGPixel added this to the 2.0.0 milestone Apr 10, 2019
@NGPixel NGPixel self-assigned this Apr 10, 2019
@NGPixel NGPixel pinned this issue Apr 10, 2019
@col-panic
Copy link

col-panic commented May 23, 2019

I am currently evaluating a new wiki system and found yours - one of the greatest features here would be to be able to paste clipboard images at the very point you're editing! This is a REAL time saver! We use it in redmine a lot (provided by this https://www.redmine.org/plugins/clipboard_image_paste plugin) Thanks

@eordano
Copy link

eordano commented Jun 9, 2019

+1 This is a real game-changer

@AchimHentschel
Copy link
Contributor

Pasting images has already been there for the 2.0 beta versions. At the moment, when taking a screenshot a long base64 encoded image is pasted into the markdown code. Unfortunately this moves the preview area to the right side of that encoded image string so no preview can be seen anymore. Would be great if these strings could be folded into a multi line representation. Alternatively the markdown panel could become horizontally scrollable so that the preview pane stays visible.

@NGPixel
Copy link
Member Author

NGPixel commented Sep 3, 2019

@AchimHentschel except that feature is still very much in early testing. The end goal is to upload them and replace with a normal resource link.

@AchimHentschel
Copy link
Contributor

@NGPixel both ways are OK for me. But if the paste of base64 encoded images remains, please consider folding the encoding (multi line) for improved readability and preview.

@nilsmich
Copy link

nilsmich commented Sep 8, 2019

It would be great to have the temporary fix for the problem with a horizontal scroll bar. Would be doable in about no time with css and be a huge improvement for the usability till the final feature is done.

Thank you for the great system :)

@NGPixel NGPixel unpinned this issue Nov 18, 2019
@NGPixel NGPixel removed this from the 2.1 milestone Jan 4, 2020
@ralphgoebel
Copy link

ralphgoebel commented Jun 20, 2020

Hi @NGPixel , first of all - I really love the work you are providing here! Will be our favorite Wiki for It documentation :) Thank you very much!

I am not a developer, but I agree to previous posts, that this feature would really be a time saver. We have some developers in our company. Do you have any idea of how much work is left to do for this feature? Is there any other way I or we could support here, to get this feature (or others) running soon? :)

Kind regards

Ralph

@iksemot
Copy link

iksemot commented Jan 5, 2021

Hey @NGPixel !

Can you share with us have you done any progress with this feature? It would sooo good to paste pictures in the Markdown editor!

Tomasz

@yeuleh
Copy link

yeuleh commented Jan 13, 2021

I'm looking forward to the feature(paste pictures), too.
Many modern markdown editors implemented this feature. It really helps a lot.

@arifeng
Copy link

arifeng commented Mar 11, 2021

Looking forward to this feature too ~

@TimoKruth
Copy link

TimoKruth commented Nov 9, 2021

Hey @NGPixel, I would like to contribute at this feature to your project as a start to maybe contribute at more points in the future. Would this be fine for you or should I start somewhere else? I would be personally motivated by this feature expecially the inline paste, thats why I came here first. Question would be are you working atm at this or would it be suited for me to work on without doubling the work done.
Alternativly I could offer help in reviewing some of the pull requests if that helps you more. I could in a first step comment if I could find any problems with the pull requests when I integrate them.
What do you think about this?

@NGPixel
Copy link
Member Author

NGPixel commented Nov 12, 2021

@TimoKruth Inline paste would be great. It's not under development atm no. Just keep in mind that Wiki.js 2.x is using CodeMirror 5 while 3.x will use CodeMirror 6, which is a total rewrite.

@naikymen
Copy link

naikymen commented Jun 9, 2023

Hi everyone, sorry to bump this old issue.

Perform file manager operations like rename, move and delete

The item is ticked, but on version 2.5.298 the Move option is grayed out:

image

Our documentation is "modularized" by subdirectories, which means that having all images in a root directory is not compatible with our layout.

It would be great to be able to upload the images to a subdirectory directly, but since the "Move" action would solve our issue I wondered if there is a way to enable it.

Thanks for the great software :)

@NGPixel
Copy link
Member Author

NGPixel commented Oct 16, 2023

Closing in favor of #6544

@NGPixel NGPixel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests