Add RUSTFLAGS

lucasmerlin · lucasmerlin · commit c61ef146dc3a · 2025-10-01T13:27:18.000+02:00
diff --git a/.cargo/config.toml b/.cargo/config.toml
@@ -1,2 +1,2 @@
 [target.wasm32-unknown-unknown]
-rustflags = ["--cfg", "getrandom_backend=\"wasm_js\""]
+rustflags = ["--cfg", "getrandom_backend=\"wasm_js\""]
diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml
@@ -17,6 +17,8 @@ permissions:
 jobs:
   build-github-pages:
     runs-on: ubuntu-latest
+    env:
+      RUSTFLAGS: '--cfg getrandom_backend="wasm_js"'
     steps:
       - uses: actions/checkout@v4 # repo checkout
       - name: Setup toolchain for wasm
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -25,6 +25,8 @@ jobs:
   check_wasm:
     name: Check wasm32
     runs-on: ubuntu-latest
+    env:
+      RUSTFLAGS: '--cfg getrandom_backend="wasm_js"'
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
@@ -89,6 +91,8 @@ jobs:
   trunk:
     name: trunk
     runs-on: ubuntu-latest
+    env:
+      RUSTFLAGS: '--cfg getrandom_backend="wasm_js"'
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
diff --git a/crates/octocrab-wasm/src/reqwest_tower_service.rs b/crates/octocrab-wasm/src/reqwest_tower_service.rs
@@ -37,14 +37,14 @@ where
         Box<dyn std::future::Future<Output = Result<Self::Response, Self::Error>> + Send>,
     >;
 
-    fn poll_ready(&mut self, cx: &mut std::task::Context<'_>) -> Poll<Result<(), Self::Error>> {
+    fn poll_ready(&mut self, _cx: &mut std::task::Context<'_>) -> Poll<Result<(), Self::Error>> {
         Poll::Ready(Ok(()))
     }
 
     fn call(&mut self, req: http::Request<Body>) -> Self::Future {
         let Self {
-            base_url: base_url,
-            client: client,
+            base_url,
+            client,
         } = self.clone();
 
         Box::pin(async move {
@@ -78,7 +78,7 @@ where
         .map_err(ReqwestTowerError::BodyError)?
         .to_bytes();
 
-    let mut uri = parts.uri;
+    let uri = parts.uri;
 
     let mut uri_parts = uri.into_parts();
     if uri_parts.authority.is_none() {
diff --git a/src/lib.rs b/src/lib.rs
@@ -2,7 +2,6 @@ use crate::github::model::{GithubArtifactLink, GithubPrLink};
 pub use crate::loaders::{DataReference, SnapshotLoader};
 use crate::state::AppState;
 use eframe::egui::Context;
-use std::path::PathBuf;
 
 pub mod app;
 mod bar;
@@ -21,9 +20,9 @@ mod viewer;
 #[derive(Debug, Clone)]
 pub enum DiffSource {
     #[cfg(not(target_arch = "wasm32"))]
-    Files(PathBuf),
+    Files(std::path::PathBuf),
     #[cfg(not(target_arch = "wasm32"))]
-    Git(PathBuf),
+    Git(std::path::PathBuf),
     Pr(GithubPrLink),
     GHArtifact(GithubArtifactLink),
     Archive(DataReference),
diff --git a/src/main.rs b/src/main.rs
@@ -33,8 +33,6 @@ fn main() -> eframe::Result<()> {
 #[cfg(target_arch = "wasm32")]
 fn parse_url_query_params() -> Option<DiffSource> {
     use kitdiff::github::auth::parse_github_artifact_url;
-    use kitdiff::github::pr::parse_github_pr_url;
-    use octocrab::models::ArtifactId;
 
     if let Some(window) = web_sys::window() {
         if let Ok(search) = window.location().search() {

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`[target.wasm32-unknown-unknown]`
`2`		`-rustflags = ["--cfg", "getrandom_backend=\"wasm_js\""]`
	`2`	`+rustflags = ["--cfg", "getrandom_backend=\"wasm_js\""]`