The plugin silently fails on lcov file that has end_of_record in a function name

[konnov]

Hi @rherrmannr!

Thank you for the amazing plugin! I started to use it today, and it really does what I expected from a coverage viewer.

Unfortunately, I've hit a bug on this line:

vscode-code-coverage-lcov/src/lcov.ts

Line 24 in 22ad55a

let absolutePath = getAbsolutePath(file.file);

I've tracked down the problem to lcov-parse. Basically, it returns malformed entries, when the file contains functions or filenames that have end_of_record as part of their name. Surprisingly, a rust library called socket2 has a function like that.

Interestingly, I am not the first one to have this issue with lcov-parse. @thomascjohnson opened a PR with a fix on December 2024. There was no movement since then, so lcov-parse does not seem to be maintained.

Anyhow, I would appreciate, if you could add a fix. Even a simple workaround for the issue with missing file field in getAbsolutePath would make it work for me:

        if (file.file) {
          let absolutePath = getAbsolutePath(file.file);
          if (absolutePath) {
              file.file = absolutePath;
          }
        }

[thomascjohnson]

Alternatively we could maintain a fork of lcov-parse with the change I proposed for this extension, but I know that's a mousetrap of its own.

[rherrmannr]

I think we can use a fork as the repo is not maintained anymore.

Maybe we can use a different parser?

[rherrmannr]

I've published a version 1.1.4, which is now using the fork of @thomascjohnson.

[rherrmannr]

Solved with 03521e6

[thomascjohnson]

Thank you!

[rherrmannr]

Let me know if it works for you

[thomascjohnson]

Works beautifully!