From c241e8d8545d7ffaddf37bb154734319c303ea13 Mon Sep 17 00:00:00 2001 From: Patrick Ludewig Date: Fri, 13 Jun 2025 11:54:11 +0200 Subject: [PATCH 1/3] fix(binders): valid html for show binder MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A value for the `hidden` attribute is not allowed, so we don’t need to set it. --- packages/core/src/binders/show.binder.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/binders/show.binder.ts b/packages/core/src/binders/show.binder.ts index c6c9dc870..0cf3ac99a 100644 --- a/packages/core/src/binders/show.binder.ts +++ b/packages/core/src/binders/show.binder.ts @@ -10,7 +10,7 @@ export class ShowBinder extends Binder { if (value) { el.removeAttribute("hidden"); } else { - el.setAttribute("hidden", "true"); + el.setAttribute("hidden"); } } } From 291c765d3d61c7982f22d05e062f330b61ef9687 Mon Sep 17 00:00:00 2001 From: Patrick Ludewig Date: Fri, 13 Jun 2025 12:33:01 +0200 Subject: [PATCH 2/3] fix(binders): add second argument for setAttribute --- packages/core/src/binders/show.binder.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/binders/show.binder.ts b/packages/core/src/binders/show.binder.ts index 0cf3ac99a..6c435895e 100644 --- a/packages/core/src/binders/show.binder.ts +++ b/packages/core/src/binders/show.binder.ts @@ -10,7 +10,7 @@ export class ShowBinder extends Binder { if (value) { el.removeAttribute("hidden"); } else { - el.setAttribute("hidden"); + el.setAttribute("hidden", ""); } } } From 1eaea4e219a79a45478bae400a720cedb91ea4b2 Mon Sep 17 00:00:00 2001 From: Patrick Ludewig Date: Fri, 13 Jun 2025 12:38:39 +0200 Subject: [PATCH 3/3] feat(binders): valid html for hidden attribute in hide binder --- packages/core/src/binders/hide.binder.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/binders/hide.binder.ts b/packages/core/src/binders/hide.binder.ts index 6fb2a770f..9e6570bab 100644 --- a/packages/core/src/binders/hide.binder.ts +++ b/packages/core/src/binders/hide.binder.ts @@ -8,7 +8,7 @@ export class HideBinder extends Binder { routine(el: HTMLElement, value: boolean) { el.style.display = value ? "none" : ""; if (value) { - el.setAttribute("hidden", "true"); + el.setAttribute("hidden", ""); } else { el.removeAttribute("hidden"); }