fix: links of breadcrumbs do not respect BASE_URL#210
Merged
eyeix merged 4 commits intoeyeix:mainfrom Apr 3, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
baseUrl empty by default when no BASE_PATH, give another slash value as default at home link.
Owner
|
@nifr Thx! |
Merged
This was referenced Apr 24, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deployed both Meilisearch and
meilisearch-uion a single instance and with aBASE_PATHof/ui/.I thought my webserver routing was incorrect after I experienced some 404s when I clicked on the breadcrumbs.
A closer look revealed that the links generated for the breadcrumbs are not correct.
This PR adds
BASE_URLas a prefix to thehrefof the breadcrumbs.